From: Eli Zaretskii <eliz@elta.co.il>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Cleanup i386-nat.c
Date: Sun, 29 Feb 2004 06:05:00 -0000 [thread overview]
Message-ID: <ullmmmnb3.fsf@elta.co.il> (raw)
In-Reply-To: <200402281538.i1SFcNds012429@elgar.kettenis.dyndns.org> (message from Mark Kettenis on Sat, 28 Feb 2004 16:38:23 +0100 (CET))
> Date: Sat, 28 Feb 2004 16:38:23 +0100 (CET)
> From: Mark Kettenis <kettenis@chello.nl>
>
> The coding style in this file had some quirks, so I committed the
> attached.
That's largely my code, so please explain the changes, so that I
never repeat any mistakes I've committed. I've read the entire
patch, and I must say that I don't understand even a single change
you made. In the comments reformatting department, I guess we have
different setting for fill-column (what is the canonical one, btw?),
but as for the rest, I don't have a clue. So please do explain.
> - /* Four(eigth on x86_64) is the maximum length an x86 debug register
> + int align = addr % max_wp_len;
> + /* Four (eigth on AMD64) is the maximum length a debug register
Here, there's a real typo in the comment, but it wasn't fixed.
next prev parent reply other threads:[~2004-02-29 6:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-28 15:38 Mark Kettenis
2004-02-29 6:05 ` Eli Zaretskii [this message]
2004-02-29 9:41 ` Mark Kettenis
2004-02-29 18:48 ` Eli Zaretskii
2004-03-19 0:09 ` Mark Kettenis
2004-03-03 20:31 ` Mark Kettenis
2004-03-04 6:11 ` Eli Zaretskii
2004-03-19 0:09 ` Eli Zaretskii
2004-03-03 6:11 ` Eli Zaretskii
2004-03-19 0:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ullmmmnb3.fsf@elta.co.il \
--to=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox