From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24027 invoked by alias); 29 Feb 2004 06:05:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24019 invoked from network); 29 Feb 2004 06:05:19 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 29 Feb 2004 06:05:19 -0000 Received: from [207.232.27.5] (helo=WST0054) by monty-python.gnu.org with asmtp (Exim 4.30) id 1AxK4k-0007Op-PB; Sun, 29 Feb 2004 01:05:19 -0500 Date: Sun, 29 Feb 2004 06:05:00 -0000 Message-Id: From: Eli Zaretskii To: Mark Kettenis CC: gdb-patches@sources.redhat.com In-reply-to: <200402281538.i1SFcNds012429@elgar.kettenis.dyndns.org> (message from Mark Kettenis on Sat, 28 Feb 2004 16:38:23 +0100 (CET)) Subject: Re: [PATCH] Cleanup i386-nat.c Reply-to: Eli Zaretskii References: <200402281538.i1SFcNds012429@elgar.kettenis.dyndns.org> X-SW-Source: 2004-02/txt/msg00883.txt.bz2 > Date: Sat, 28 Feb 2004 16:38:23 +0100 (CET) > From: Mark Kettenis > > The coding style in this file had some quirks, so I committed the > attached. That's largely my code, so please explain the changes, so that I never repeat any mistakes I've committed. I've read the entire patch, and I must say that I don't understand even a single change you made. In the comments reformatting department, I guess we have different setting for fill-column (what is the canonical one, btw?), but as for the rest, I don't have a clue. So please do explain. > - /* Four(eigth on x86_64) is the maximum length an x86 debug register > + int align = addr % max_wp_len; > + /* Four (eigth on AMD64) is the maximum length a debug register Here, there's a real typo in the comment, but it wasn't fixed.