Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Improve "help all"
Date: Sat, 28 Oct 2006 11:29:00 -0000	[thread overview]
Message-ID: <ulkn0u1ae.fsf@gnu.org> (raw)
In-Reply-To: <200610272340.26372.vladimir@codesourcery.com> (message from 	Vladimir Prus on Fri, 27 Oct 2006 23:40:26 +0400)

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 27 Oct 2006 23:40:26 +0400
> 
> at the moment gdb's "help all" command is not as helpful as it could be 
> because:
> 
> 1. It's not mentioned in the output of "help".
> 2. The output of "help all" lacks any structure -- like visual grouping by 
> classes.
> 3. The prefix commands are printed in weird order. For example, the
> "append" and "append binary" commands are printed a couple of screens apart.
> 
> This patch fixes all that, and also mentions "apropos" in the output 
> of "help".

Thanks.

The idea sounds very good to me, but could you please post the output
of "help all" after applying the patch, so the improved results are
clearly visible?  It's hard to judge that based only on the code
changes, and at least I cannot easily build a patched version where
I'm typing this.

> diff -u -r1.54 command.h
> --- command.h	17 Dec 2005 22:33:59 -0000	1.54
> +++ command.h	27 Oct 2006 19:39:27 -0000
> @@ -30,7 +30,7 @@
>  enum command_class
>  {
>    /* Special args to help_list */
> -  class_deprecated, all_classes = -2, all_commands = -1,
> +  class_deprecated = -3, all_classes = -2, all_commands = -1,
>    /* Classes of commands */
>    no_class = -1, class_run = 0, class_vars, class_stack,
>    class_files, class_support, class_info, class_breakpoint, class_trace,

I suggest to simply move class_deprecated after no_class, so that the
compiler gives it a value.  We don't really care about the value in
that case, do we?


  reply	other threads:[~2006-10-28 11:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-27 19:40 Vladimir Prus
2006-10-28 11:29 ` Eli Zaretskii [this message]
2006-10-28 11:58   ` Vladimir Prus
2006-10-28 12:26     ` Eli Zaretskii
2006-10-28 15:29       ` Daniel Jacobowitz
2006-10-28 18:57         ` Eli Zaretskii
2006-10-31 12:11         ` Vladimir Prus
2006-10-31 12:30           ` Mark Kettenis
2006-10-31 22:28             ` Eli Zaretskii
2006-11-01  9:51               ` Vladimir Prus
2006-11-01 20:16                 ` Eli Zaretskii
2006-11-01 22:50                   ` Mark Kettenis
2006-11-02  4:19                     ` Eli Zaretskii
2006-10-31 12:15       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ulkn0u1ae.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox