From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22220 invoked by alias); 28 Oct 2006 11:29:02 -0000 Received: (qmail 22206 invoked by uid 22791); 28 Oct 2006 11:29:00 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 28 Oct 2006 11:28:58 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-238-159.inter.net.il [84.229.238.159]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id FAL87619 (AUTH halo1); Sat, 28 Oct 2006 13:28:52 +0200 (IST) Date: Sat, 28 Oct 2006 11:29:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200610272340.26372.vladimir@codesourcery.com> (message from Vladimir Prus on Fri, 27 Oct 2006 23:40:26 +0400) Subject: Re: Improve "help all" Reply-to: Eli Zaretskii References: <200610272340.26372.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00299.txt.bz2 > From: Vladimir Prus > Date: Fri, 27 Oct 2006 23:40:26 +0400 > > at the moment gdb's "help all" command is not as helpful as it could be > because: > > 1. It's not mentioned in the output of "help". > 2. The output of "help all" lacks any structure -- like visual grouping by > classes. > 3. The prefix commands are printed in weird order. For example, the > "append" and "append binary" commands are printed a couple of screens apart. > > This patch fixes all that, and also mentions "apropos" in the output > of "help". Thanks. The idea sounds very good to me, but could you please post the output of "help all" after applying the patch, so the improved results are clearly visible? It's hard to judge that based only on the code changes, and at least I cannot easily build a patched version where I'm typing this. > diff -u -r1.54 command.h > --- command.h 17 Dec 2005 22:33:59 -0000 1.54 > +++ command.h 27 Oct 2006 19:39:27 -0000 > @@ -30,7 +30,7 @@ > enum command_class > { > /* Special args to help_list */ > - class_deprecated, all_classes = -2, all_commands = -1, > + class_deprecated = -3, all_classes = -2, all_commands = -1, > /* Classes of commands */ > no_class = -1, class_run = 0, class_vars, class_stack, > class_files, class_support, class_info, class_breakpoint, class_trace, I suggest to simply move class_deprecated after no_class, so that the compiler gives it a value. We don't really care about the value in that case, do we?