From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: deuling@de.ibm.com, gdb-patches@sourceware.org
Subject: Re: [Patch]: Little Cleanup
Date: Sat, 03 Mar 2007 10:29:00 -0000 [thread overview]
Message-ID: <ulkie62od.fsf@gnu.org> (raw)
In-Reply-To: <45E93AE5.5050704@portugalmail.pt> (message from Pedro Alves on Sat, 03 Mar 2007 09:07:49 +0000)
> Date: Sat, 03 Mar 2007 09:07:49 +0000
> From: Pedro Alves <pedro_alves@portugalmail.pt>
> CC: GDB Patches <gdb-patches@sourceware.org>
>
> Markus Deuling wrote:
> > @@ -2909,8 +2902,7 @@
> >
> > if (!breakpoints_inserted && !ecs->another_trap)
> > {
> > - breakpoints_failed = insert_breakpoints ();
> > - if (breakpoints_failed)
> > + if (insert_breakpoints ())
> > {
> > stop_stepping (ecs);
> > return;
> >
> >
>
> Actually, I find your version harder to read for someone not knowing the
> insert_breakpoints API by heart.
FWIW, I agree. The new version requires a comment to be as readable
as the old one.
(Of course, I'd expect the optimizer to produce the same code from
both old and new versions.)
next prev parent reply other threads:[~2007-03-03 10:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 7:04 Markus Deuling
2007-03-03 9:08 ` Pedro Alves
2007-03-03 10:29 ` Eli Zaretskii [this message]
2007-03-05 5:59 ` Markus Deuling
2007-03-05 21:04 ` Eli Zaretskii
2007-03-05 21:23 ` Mark Kettenis
2007-03-05 21:23 ` Eli Zaretskii
2007-03-05 22:01 ` Jim Blandy
2007-03-06 4:22 ` Eli Zaretskii
2007-03-06 19:53 ` Joel Brobecker
2007-03-06 20:40 ` Michael Snyder
2007-03-06 21:03 ` Eli Zaretskii
2007-03-06 22:10 ` Ulrich Weigand
2007-03-07 7:36 ` Markus Deuling
2007-03-07 12:15 ` Daniel Jacobowitz
2007-03-07 16:34 ` Eli Zaretskii
2007-03-09 4:48 ` Markus Deuling
2007-03-09 16:21 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ulkie62od.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox