From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30442 invoked by alias); 3 Mar 2007 10:29:06 -0000 Received: (qmail 30433 invoked by uid 22791); 3 Mar 2007 10:29:05 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 03 Mar 2007 10:29:00 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-146-218.inter.net.il [80.230.146.218]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id CAH51625 (AUTH halo1); Sat, 3 Mar 2007 12:28:51 +0200 (IST) Date: Sat, 03 Mar 2007 10:29:00 -0000 Message-Id: From: Eli Zaretskii To: Pedro Alves CC: deuling@de.ibm.com, gdb-patches@sourceware.org In-reply-to: <45E93AE5.5050704@portugalmail.pt> (message from Pedro Alves on Sat, 03 Mar 2007 09:07:49 +0000) Subject: Re: [Patch]: Little Cleanup Reply-to: Eli Zaretskii References: <45E7CC17.5040304@de.ibm.com> <45E93AE5.5050704@portugalmail.pt> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00024.txt.bz2 > Date: Sat, 03 Mar 2007 09:07:49 +0000 > From: Pedro Alves > CC: GDB Patches > > Markus Deuling wrote: > > @@ -2909,8 +2902,7 @@ > > > > if (!breakpoints_inserted && !ecs->another_trap) > > { > > - breakpoints_failed = insert_breakpoints (); > > - if (breakpoints_failed) > > + if (insert_breakpoints ()) > > { > > stop_stepping (ecs); > > return; > > > > > > Actually, I find your version harder to read for someone not knowing the > insert_breakpoints API by heart. FWIW, I agree. The new version requires a comment to be as readable as the old one. (Of course, I'd expect the optimizer to produce the same code from both old and new versions.)