[patch] mingw to handle abs. path to core

[patch] mingw to handle abs. path to core

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hello,

When built for mingw target, gdb will misinterpret full path to core file.

The fix is very simple (patch attached).

---
Aleksandar Ristovski
QNX Software Systems



ChangeLog:

2008-02-04  Aleksandar Ristovski  <aristovski@qnx.com>

	* corelow.c (core_open): Use IS_ABSOLUTE_PATH.
	(filenames.h): New include.
	* Makefile.in (corelow.o): Added dependency.


[-- Attachment #2: mingwfullpathcore.diff --]
[-- Type: text/plain, Size: 1509 bytes --]

Index: gdb/corelow.c
===================================================================
RCS file: /cvs/src/src/gdb/corelow.c,v
retrieving revision 1.72
diff -u -p -r1.72 corelow.c
--- gdb/corelow.c	16 Jan 2008 01:17:24 -0000	1.72
+++ gdb/corelow.c	4 Feb 2008 19:35:37 -0000
@@ -44,6 +44,7 @@
 #include "gdb_assert.h"
 #include "exceptions.h"
 #include "solib.h"
+#include "filenames.h"
 
 
 #ifndef O_LARGEFILE
@@ -271,7 +272,7 @@ core_open (char *filename, int from_tty)
     }
 
   filename = tilde_expand (filename);
-  if (filename[0] != '/')
+  if (!IS_ABSOLUTE_PATH(filename))
     {
       temp = concat (current_directory, "/", filename, (char *)NULL);
       xfree (filename);
Index: gdb/Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.978
diff -u -p -r1.978 Makefile.in
--- gdb/Makefile.in	30 Jan 2008 07:17:31 -0000	1.978
+++ gdb/Makefile.in	4 Feb 2008 19:35:40 -0000
@@ -1995,7 +1995,7 @@ corelow.o: corelow.c $(defs_h) $(arch_ut
 	$(inferior_h) $(symtab_h) $(command_h) $(bfd_h) $(target_h) \
 	$(gdbcore_h) $(gdbthread_h) $(regcache_h) $(regset_h) $(symfile_h) \
 	$(exec_h) $(readline_h) $(gdb_assert_h) \
-	$(exceptions_h) $(solib_h)
+	$(exceptions_h) $(solib_h) $(filenames_h)
 core-regset.o: core-regset.c $(defs_h) $(command_h) $(gdbcore_h) \
 	$(inferior_h) $(target_h) $(regcache_h) $(gdb_string_h) $(gregset_h)
 cp-abi.o: cp-abi.c $(defs_h) $(value_h) $(cp_abi_h) $(command_h) $(gdbcmd_h) \

Re: [patch] mingw to handle abs. path to core

[Eli Zaretskii]

> Date: Mon, 04 Feb 2008 14:39:39 -0500
> From: Aleksandar Ristovski <aristovski@qnx.com>
> 
> When built for mingw target, gdb will misinterpret full path to core file.
> 
> The fix is very simple (patch attached).

Good catch.  Thanks, your patch is okay.

Re: [patch] mingw to handle abs. path to core

[Aleksandar Ristovski]

Eli Zaretskii wrote:
>> Date: Mon, 04 Feb 2008 14:39:39 -0500
>> From: Aleksandar Ristovski <aristovski@qnx.com>
>>
>> When built for mingw target, gdb will misinterpret full path to core file.
>>
>> The fix is very simple (patch attached).
> 
> Good catch.  Thanks, your patch is okay.
> 
Eli, thanks for looking. I do not, however, have write access to CVS... so if 
one of the gdb elders could commit it, that would be great.

Thanks,
Aleksandar

Re: [patch] mingw to handle abs. path to core

[Eli Zaretskii]

> Date: Tue, 05 Feb 2008 11:58:10 -0500
> From: Aleksandar Ristovski <aristovski@qnx.com>
> CC: gdb-patches@sourceware.org
> 
> Eli Zaretskii wrote:
> >> Date: Mon, 04 Feb 2008 14:39:39 -0500
> >> From: Aleksandar Ristovski <aristovski@qnx.com>
> >>
> >> When built for mingw target, gdb will misinterpret full path to core file.
> >>
> >> The fix is very simple (patch attached).
> > 
> > Good catch.  Thanks, your patch is okay.
> > 
> Eli, thanks for looking. I do not, however, have write access to CVS... so if 
> one of the gdb elders could commit it, that would be great.

Done.