Re: [patch] build-id .debug files load (like .gnu_debuglink)

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sat, 1 Sep 2007 13:35:30 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org, roland@redhat.com
> 
> >   . The objcopy commands shown in your patch seem to be relevant only
> >     to the ``debug link'' method (at least that's what I understand
> >     from the last objcopy command).  If so, I think we should say what
> >     are the corresponding commands for the ``debug ID'' method.
> >     Likewise, if there are (or going to be) features in elfutils that
> >     support ``debug ID'', I think we should mention them, as we do for
> >     ``debug links'' now.
> 
> ``debug ID'' gets included by `ld --build-id', therefore by `gcc
> -Wl,--build-id', it is still not default in FSF GCC.  There are no specific
> splitting commands required (such as `objcopy --add-gnu-debuglink' for the
> former "debug link".

But the first command, the one to create the separate debug info file,
is still needed, right?

In any case, we should tell that these commands (or at least the last
one) is only needed for the debug-link method.

> --- gdb/NEWS	28 Aug 2007 19:57:11 -0000	1.236
> +++ gdb/NEWS	1 Sep 2007 11:29:43 -0000
> @@ -61,6 +61,9 @@ Windows and SymbianOS).
>  * The GDB remote stub, gdbserver, now supports dynamic link libraries
>  (DLLs) on Windows and Windows CE targets.
>  
> +* GDB now supports a faster verification a .debug file matches its binary
                                          ^^^
"that" is missing here.

> +according to its build-id signature, if the signature present.
                                                       ^^^
"if the signature is present", the "is" part is missing.

> +``Debug ID'' gets embedded into the main executable using @code{ld --build-id}
> +or the @value{NGCC} counterpart @code{gcc -Wl,--build-id}.  ``Debug ID''
> +support plus compatibility fixes for debug files separation are present in
> +@sc{gnu} binary utilities (Binutils) since version 2.17.50.0.18.

This is fine, but there's no need to quote ``debug ID'' every time you
use it.  I quoted it only when I used it as a name of a method of
embedding information about the debug file; in other cases I used it
without quotes.

Otherwise, these two patches are okay with me.

Thanks.