From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Roland McGrath <roland@redhat.com>
Subject: Re: [patch] build-id .debug files load (like .gnu_debuglink)
Date: Sat, 25 Aug 2007 23:58:00 -0000 [thread overview]
Message-ID: <20070825235805.GA11876@caradoc.them.org> (raw)
In-Reply-To: <20070825224914.GA11255@host0.dyn.jankratochvil.net>
On Sun, Aug 26, 2007 at 12:49:14AM +0200, Jan Kratochvil wrote:
> You are right about the content of `/lib64/ld-linux-x86-64.so.2'.
> Still in such case both `.dynsym' and `.symtab' gets read into MSYMBOLS but
> PSYMTABS and SYMTABS are left forever NULL for the main executable (as there is
> no .debug_info).
>
> While I would still expect the former patch was right I changed it according to
> your advice. It is definitely the safe way but with a tiny performance hit:
>
> The reason of my check was that build-id (contrary to the debug-link) is always
> present there, even for locally built unsplit files. With the patch attached
> below GDB will try to open a separate debug file in /usr/lib/debug/.debug-id/
> even for the unsplit files. This step did not happen with my former patch.
Right. There's two other ways we could check, which Roland suggested:
presence of .gnu_debuglink and presence of .debug_info.
I misread your original patch. If there's no .debug_info then there
won't be any psymtabs. So that's probably the best check, and I
apologize for the bad advice. I don't want to check for
.gnu_debuglink; in the future maybe files which use build ID won't
have a .gnu_debuglink section any more.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-25 23:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 18:05 Jan Kratochvil
2007-08-24 18:20 ` Daniel Jacobowitz
2007-08-25 22:49 ` Jan Kratochvil
2007-08-25 23:58 ` Daniel Jacobowitz [this message]
2007-08-26 9:41 ` Jan Kratochvil
2007-08-31 9:38 ` Eli Zaretskii
2007-08-31 20:51 ` [patch approval?] " Jan Kratochvil
2007-08-31 21:12 ` Daniel Jacobowitz
2007-09-01 8:01 ` Eli Zaretskii
[not found] ` <20070901081934.GA31205@host0.dyn.jankratochvil.net>
2007-09-01 10:31 ` [patch] " Eli Zaretskii
2007-09-01 11:35 ` Jan Kratochvil
2007-09-01 12:15 ` Eli Zaretskii
2007-09-01 13:12 ` Jan Kratochvil
2007-09-01 13:25 ` Mark Kettenis
2007-09-01 14:22 ` Eli Zaretskii
2007-09-02 13:57 ` [patch approved?] [doc] " Jan Kratochvil
2007-09-02 17:49 ` Mark Kettenis
2007-09-02 19:38 ` Eli Zaretskii
2007-09-01 14:16 ` [patch] " Eli Zaretskii
2007-09-04 2:21 ` Roland McGrath
2007-09-04 3:23 ` Eli Zaretskii
2007-09-04 7:21 ` Roland McGrath
2007-09-15 9:52 ` Eli Zaretskii
2007-09-16 17:19 ` Roland McGrath
2007-08-25 22:48 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070825235805.GA11876@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox