From: Eli Zaretskii <eliz@gnu.org>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] catchpoints bring output in-line with breakpoints output
Date: Wed, 28 May 2008 16:25:00 -0000 [thread overview]
Message-ID: <uiqwz8mcw.fsf@gnu.org> (raw)
In-Reply-To: <483C685D.5030503@qnx.com>
> From: Aleksandar Ristovski <aristovski@qnx.com>
> Date: Tue, 27 May 2008 16:00:29 -0400
>
> >> + int bp_temp;
> >> + char msg[160];
> >> + const char * msgspec;
> >> + const char msgfmt[] = "\n%s %d (exception %s)\n";
> >
> > This is not a good idea, because it defeats translation. For
> > starters, this format string will not be caught by xgettext and won't
> > be in the message catalog. Moreover, ...
>
> Changed accordingly. I also adjusted MI output to better fit into breakpoint pattern. New diff attached.
Thanks, I'm happy now.
next prev parent reply other threads:[~2008-05-27 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 20:01 Aleksandar Ristovski
2008-05-27 21:32 ` Aleksandar Ristovski
2008-05-27 23:25 ` Eli Zaretskii
2008-05-28 15:20 ` Aleksandar Ristovski
2008-05-28 16:25 ` Eli Zaretskii [this message]
2008-05-28 19:31 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uiqwz8mcw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox