From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11407 invoked by alias); 27 May 2008 21:32:18 -0000 Received: (qmail 11398 invoked by uid 22791); 27 May 2008 21:32:18 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 May 2008 21:31:59 +0000 Received: from HOME-C4E4A596F7 ([83.130.219.40]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K1J0028QR5TFVQ0@i_mtaout2.012.net.il> for gdb-patches@sources.redhat.com; Wed, 28 May 2008 00:46:42 +0300 (IDT) Date: Wed, 28 May 2008 16:25:00 -0000 From: Eli Zaretskii Subject: Re: [patch] catchpoints bring output in-line with breakpoints output In-reply-to: <483C685D.5030503@qnx.com> X-012-Sender: halo1@inter.net.il To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: References: <483C685D.5030503@qnx.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00724.txt.bz2 > From: Aleksandar Ristovski > Date: Tue, 27 May 2008 16:00:29 -0400 > > >> + int bp_temp; > >> + char msg[160]; > >> + const char * msgspec; > >> + const char msgfmt[] = "\n%s %d (exception %s)\n"; > > > > This is not a good idea, because it defeats translation. For > > starters, this format string will not be caught by xgettext and won't > > be in the message catalog. Moreover, ... > > Changed accordingly. I also adjusted MI output to better fit into breakpoint pattern. New diff attached. Thanks, I'm happy now.