From: Eli Zaretskii <eliz@gnu.org>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Problem union comparision in TUI
Date: Mon, 24 Oct 2005 11:06:00 -0000 [thread overview]
Message-ID: <uhdb7gonl.fsf@gnu.org> (raw)
In-Reply-To: <435CB6BC.7040101@st.com> (message from Andrew STUBBS on Mon, 24 Oct 2005 11:26:04 +0100)
> Date: Mon, 24 Oct 2005 11:26:04 +0100
> From: Andrew STUBBS <andrew.stubbs@st.com>
> Cc: gdb-patches@sources.redhat.com
>
> Eli Zaretskii wrote:
> > Why didn't you test l.loa to be LOA_ADDRESS before comparing the
> > addresses?
>
> In theory it must be na address if it isn't a line. If it wasn't an
> address then what should the code do?
It should use gdb_assert to signal a fatal internal error. If that
error is ever reported, we will have a recipe to reproduce the bug,
and then we could fix it.
next prev parent reply other threads:[~2005-10-24 11:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 14:52 Andrew STUBBS
2005-10-17 15:02 ` Andrew STUBBS
2005-10-19 9:15 ` Eli Zaretskii
2005-10-19 9:51 ` Andrew STUBBS
2005-10-19 12:28 ` Daniel Jacobowitz
2005-10-19 16:22 ` Andrew STUBBS
2005-10-19 20:03 ` Eli Zaretskii
2005-10-19 20:08 ` Daniel Jacobowitz
2005-10-19 20:22 ` Mark Kettenis
2005-10-20 8:43 ` Eli Zaretskii
2005-10-20 10:18 ` Andrew STUBBS
2005-10-20 16:20 ` Andrew STUBBS
2005-10-20 17:56 ` Daniel Jacobowitz
2005-10-20 19:41 ` Eli Zaretskii
2005-10-21 14:55 ` Andrew STUBBS
2005-10-21 16:39 ` Daniel Jacobowitz
2005-10-21 22:03 ` Eli Zaretskii
2005-10-21 22:13 ` Eli Zaretskii
2005-10-24 10:28 ` Andrew STUBBS
2005-10-24 11:06 ` Eli Zaretskii [this message]
2005-10-24 12:56 ` Andrew STUBBS
2005-10-25 10:45 ` Eli Zaretskii
2005-11-01 16:24 ` Andrew STUBBS
2005-11-01 16:28 ` Daniel Jacobowitz
2005-11-01 17:43 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uhdb7gonl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox