From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8733 invoked by alias); 24 Oct 2005 11:06:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8721 invoked by uid 22791); 24 Oct 2005 11:06:33 -0000 Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 24 Oct 2005 11:06:33 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-163-213.inter.net.il [84.228.163.213]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id CTX44924 (AUTH halo1); Mon, 24 Oct 2005 13:06:22 +0200 (IST) Date: Mon, 24 Oct 2005 11:06:00 -0000 Message-Id: From: Eli Zaretskii To: Andrew STUBBS CC: gdb-patches@sources.redhat.com In-reply-to: <435CB6BC.7040101@st.com> (message from Andrew STUBBS on Mon, 24 Oct 2005 11:26:04 +0100) Subject: Re: PATCH: Problem union comparision in TUI Reply-to: Eli Zaretskii References: <4353BA69.1030401@st.com> <43561685.3010300@st.com> <20051019200751.GA19037@nevyn.them.org> <43576E68.8080804@st.com> <4357C346.8070400@st.com> <435900C7.2010706@st.com> <435CB6BC.7040101@st.com> X-SW-Source: 2005-10/txt/msg00187.txt.bz2 > Date: Mon, 24 Oct 2005 11:26:04 +0100 > From: Andrew STUBBS > Cc: gdb-patches@sources.redhat.com > > Eli Zaretskii wrote: > > Why didn't you test l.loa to be LOA_ADDRESS before comparing the > > addresses? > > In theory it must be na address if it isn't a line. If it wasn't an > address then what should the code do? It should use gdb_assert to signal a fatal internal error. If that error is ever reported, we will have a recipe to reproduce the bug, and then we could fix it.