From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfa/doc] Re: RFC: A change to the way we initialize new gdbarches
Date: Fri, 10 Nov 2006 15:33:00 -0000 [thread overview]
Message-ID: <uhcx7jp00.fsf@gnu.org> (raw)
In-Reply-To: <20061109195012.GB14732@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 9 Nov 2006 14:50:12 -0500)
> Date: Thu, 9 Nov 2006 14:50:12 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> Index: src/gdb/doc/gdbint.texinfo
> ===================================================================
> --- src.orig/gdb/doc/gdbint.texinfo 2006-11-09 14:14:55.000000000 -0500
> +++ src/gdb/doc/gdbint.texinfo 2006-11-09 14:33:05.000000000 -0500
Thanks. This patch is fine with me, except for the following minor
comment:
> +The initialization function has this type:
> +
> +@smallexample
> +static struct gdbarch *
> +@var{arch}_gdbarch_init (struct gdbarch_info info,
> + struct gdbarch_list *arches)
> +@end smallexample
> +
> +The @var{info} argument contains parameters used to select the correct
> +architecture, and @var{arches} is a list of architectures which
I think both `info' and `arches' should have a @var markup in the
@smallexample as well, to make them consistent with the following text
that describes them.
next prev parent reply other threads:[~2006-11-10 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 23:10 Daniel Jacobowitz
2006-10-05 20:06 ` Mark Kettenis
2006-10-05 20:25 ` Daniel Jacobowitz
2006-10-18 20:48 ` Daniel Jacobowitz
2006-10-19 20:00 ` Joel Brobecker
2006-11-09 19:50 ` [rfa/doc] " Daniel Jacobowitz
2006-11-09 21:23 ` Eli Zaretskii
2006-11-10 15:33 ` Eli Zaretskii [this message]
2006-11-10 16:56 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uhcx7jp00.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox