From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46061-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13132 invoked by alias); 10 Nov 2006 15:33:23 -0000
Received: (qmail 13098 invoked by uid 22791); 10 Nov 2006 15:33:21 -0000
X-Spam-Check-By: sourceware.org
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Nov 2006 15:33:12 +0000
Received: from HOME-C4E4A596F7 (IGLD-84-229-231-70.inter.net.il [84.229.231.70]) 	by nitzan.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id FDL07425 (AUTH halo1); 	Fri, 10 Nov 2006 17:33:05 +0200 (IST)
Date: Fri, 10 Nov 2006 15:33:00 -0000
Message-Id: <uhcx7jp00.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
CC: gdb-patches@sourceware.org
In-reply-to: <20061109195012.GB14732@nevyn.them.org> (message from Daniel 	Jacobowitz on Thu, 9 Nov 2006 14:50:12 -0500)
Subject: Re: [rfa/doc] Re: RFC: A change to the way we initialize new gdbarches
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <20061004231025.GA9687@nevyn.them.org> <200610052006.k95K69UK024656@elgar.sibelius.xs4all.nl> <20061005202536.GA10876@nevyn.them.org> <20061018204802.GA20757@nevyn.them.org> <20061109195012.GB14732@nevyn.them.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00065.txt.bz2

> Date: Thu, 9 Nov 2006 14:50:12 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Index: src/gdb/doc/gdbint.texinfo
> ===================================================================
> --- src.orig/gdb/doc/gdbint.texinfo	2006-11-09 14:14:55.000000000 -0500
> +++ src/gdb/doc/gdbint.texinfo	2006-11-09 14:33:05.000000000 -0500

Thanks.  This patch is fine with me, except for the following minor
comment:

> +The initialization function has this type:
> +
> +@smallexample
> +static struct gdbarch *
> +@var{arch}_gdbarch_init (struct gdbarch_info info,
> +                         struct gdbarch_list *arches)
> +@end smallexample
> +
> +The @var{info} argument contains parameters used to select the correct
> +architecture, and @var{arches} is a list of architectures which

I think both `info' and `arches' should have a @var markup in the
@smallexample as well, to make them consistent with the following text
that describes them.