Re: Patch to update gdbint.texinfo [00/05]

[Eli Zaretskii <eliz@gnu.org>]

> From: Jeremy Bennett <jeremy.bennett@embecosm.com>
> Date: Sat, 20 Sep 2008 19:38:16 +0100
> 
> > However, I don't see your name in the FSF records of copyright
> > assignments.  If you didn't submit legal paperwork to the FSF, please
> > do, because your contribution is substantial to require that.  We
> > cannot use such large patches without legal papers.
> 
> I sent an email to assign@gnu.org yesterday requesting help in assigning
> the copyright. The text has been taken from an existing paper under
> Creative Commons Attribution 2.0 license with the copyright owned by
> Embecosm (my company). However we're very happy to assign the rights to
> all contributions to FSF.
> 
> Anything you can do to expedite this would be appreciated

Daniel, can you help out here?

> @deftypefn {Architecture Function} struct frame_id unwind_dummy_id
> (struct gdbarch *@var{gdbarch}, struct frame_info *@var{next_frame})
> 
> puts "frame_id" into the index, not "unwind_dummy_id". I can fix it by
> using:
> 
> @deftypefn {Architecture Function} {struct frame_id} unwind_dummy_id
> (struct gdbarch *@var{gdbarch}, struct frame_info *@var{next_frame})

Yes, that's the way to go.

> > > +  if( 0 == n ) @{
> > > +    return 1;
> > > +  @}
> > > +  else @{
> > > +    return n * fact( n - 1 );
> > > +  @}
> > 
> > This is not the GNU style of formatting C code.  Please use the GNU
> > style.
> 
> This was deliberate - the diagram has the code squashed up like this, so
> it fits in the space available, and I've used the text from the diagram
> literally.

Okay, but then please add a comment before this example explaining
this reason.