From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58733-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22077 invoked by alias); 20 Sep 2008 19:38:21 -0000
Received: (qmail 22068 invoked by uid 22791); 20 Sep 2008 19:38:19 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 20 Sep 2008 19:37:40 +0000
Received: from HOME-C4E4A596F7 ([77.127.116.246]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K7I006PNEIWDA50@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Sat, 20 Sep 2008 22:37:45 +0300 (IDT)
Date: Sat, 20 Sep 2008 19:38:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Patch to update gdbint.texinfo [00/05]
In-reply-to: <1221935896.2827.545.camel@thomas>
X-012-Sender: halo1@inter.net.il
To: jeremy.bennett@embecosm.com
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uhc8apq28.fsf@gnu.org>
References: <1221919290.2827.495.camel@thomas> <umyi2px4a.fsf@gnu.org> <1221935896.2827.545.camel@thomas>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00444.txt.bz2

> From: Jeremy Bennett <jeremy.bennett@embecosm.com>
> Date: Sat, 20 Sep 2008 19:38:16 +0100
> 
> > However, I don't see your name in the FSF records of copyright
> > assignments.  If you didn't submit legal paperwork to the FSF, please
> > do, because your contribution is substantial to require that.  We
> > cannot use such large patches without legal papers.
> 
> I sent an email to assign@gnu.org yesterday requesting help in assigning
> the copyright. The text has been taken from an existing paper under
> Creative Commons Attribution 2.0 license with the copyright owned by
> Embecosm (my company). However we're very happy to assign the rights to
> all contributions to FSF.
> 
> Anything you can do to expedite this would be appreciated

Daniel, can you help out here?

> @deftypefn {Architecture Function} struct frame_id unwind_dummy_id
> (struct gdbarch *@var{gdbarch}, struct frame_info *@var{next_frame})
> 
> puts "frame_id" into the index, not "unwind_dummy_id". I can fix it by
> using:
> 
> @deftypefn {Architecture Function} {struct frame_id} unwind_dummy_id
> (struct gdbarch *@var{gdbarch}, struct frame_info *@var{next_frame})

Yes, that's the way to go.

> > > +  if( 0 == n ) @{
> > > +    return 1;
> > > +  @}
> > > +  else @{
> > > +    return n * fact( n - 1 );
> > > +  @}
> > 
> > This is not the GNU style of formatting C code.  Please use the GNU
> > style.
> 
> This was deliberate - the diagram has the code squashed up like this, so
> it fits in the space available, and I've used the text from the diagram
> literally.

Okay, but then please add a comment before this example explaining
this reason.