Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com, drow@false.org
Subject: Re: [remote/rfc] Let GDB know if a remote server originally attached to a process.
Date: Sat, 07 Mar 2009 10:29:00 -0000	[thread overview]
Message-ID: <ufxhpmxrd.fsf@gnu.org> (raw)
In-Reply-To: <200903062124.02268.pedro@codesourcery.com>

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 6 Mar 2009 21:24:01 +0000
> Cc: Joel Brobecker <brobecker@adacore.com>,
>  Daniel Jacobowitz <drow@false.org>,
>  Eli Zaretskii <eliz@gnu.org>
> 
> Eli, is the documentation addition OK?

I have a few comments.

> +@item qAttached:@var{pid}
> +@cindex query attached, remote request
> +@cindex @samp{qAttached} packet
> +Return if the remote target is attached to the process with the
> +specified process ID, instead of having created it.

This sentence probably needs to be rephrased, but I don't understand
what it means, and so cannot suggest how to rephrase it.  It sounds
like you meant to say "Return an indication of whether the remote
target is attached ...", but then what is the purpose of adding
"instead of having created it"?  Could you please explain?

> @var{pid} is a
> +hexadecimal integer identifying the target process.

There's no such thing as "hexadecimal integer".  I think you mean
"an integer in hexadecimal format".

> +This query is used to, for example, know whether the remote process

Don't separate "to" from its verb:

  This query is used, for example, to know whether ...

Thanks.


  reply	other threads:[~2009-03-07 10:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  1:17 Pedro Alves
2009-03-04 19:18 ` Joel Brobecker
2009-03-06 21:24   ` Pedro Alves
2009-03-07 10:29     ` Eli Zaretskii [this message]
2009-03-07 12:27       ` Pedro Alves
2009-03-07 14:20         ` Eli Zaretskii
2009-03-07 14:53           ` Pedro Alves
2009-03-07 15:58             ` Eli Zaretskii
2009-03-13 16:14     ` Daniel Jacobowitz
2009-03-14 10:22       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ufxhpmxrd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox