From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [remote/rfc] Let GDB know if a remote server originally attached to a process.
Date: Wed, 04 Mar 2009 19:18:00 -0000 [thread overview]
Message-ID: <20090304191800.GB3729@adacore.com> (raw)
In-Reply-To: <200903040117.32166.pedro@codesourcery.com>
> There's an obvious workaround for this (detach explicitly, then quit GDB),
> but this ought to be changed for consistency (*).
I agree. Not only that, but differences like these can be very annoying
when setting up automated testing. You write a test script that expects
one thing because that's what happens in the native case, then all of
a sudden, you have an exception when using gdbserver...
> This is simple enough --- the patch is smaller than this
> whole description of it :-) I was considering if we want to
> generalize a mechanism for this or not, say similar to target
> descriptions, but I don't have any other use case for such a thing.
I'm not very familiar with the remote protocol, but I don't see much
benefit in generalizing this approach. Perhaps you'd like to expand,
but I'm happy with the simple approach you took.
The patch looks OK to me too. There are one or two new functions
that are undocumented, and we've been bugging contributors about this,
so it'd be nice to have a short description preceding them. Other than
that, no comment.
--
Joel
next prev parent reply other threads:[~2009-03-04 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 1:17 Pedro Alves
2009-03-04 19:18 ` Joel Brobecker [this message]
2009-03-06 21:24 ` Pedro Alves
2009-03-07 10:29 ` Eli Zaretskii
2009-03-07 12:27 ` Pedro Alves
2009-03-07 14:20 ` Eli Zaretskii
2009-03-07 14:53 ` Pedro Alves
2009-03-07 15:58 ` Eli Zaretskii
2009-03-13 16:14 ` Daniel Jacobowitz
2009-03-14 10:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304191800.GB3729@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox