From: Eli Zaretskii <eliz@gnu.org>
To: Jim Blandy <jimb@red-bean.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fwd: Obvious: doc fix for 'struct memrange' in tracepoints.c
Date: Sat, 19 Nov 2005 12:56:00 -0000 [thread overview]
Message-ID: <uek5chpln.fsf@gnu.org> (raw)
In-Reply-To: <8f2776cb0511182045h5fe6b1a7ye0811b1bfaa74a59@mail.gmail.com> (message from Jim Blandy on Fri, 18 Nov 2005 20:45:28 -0800)
> Date: Fri, 18 Nov 2005 20:45:28 -0800
> From: Jim Blandy <jimb@red-bean.com>
>
> *** gdb/tracepoint.c 19 Nov 2005 01:23:26 -0000 1.79
> --- gdb/tracepoint.c 19 Nov 2005 04:42:36 -0000
> *************** collect_symbol (struct collection_list *
> *** 1226,1232 ****
> DEPRECATED_SYMBOL_NAME (sym), len,
> tmp /* address */);
> }
> ! add_memrange (collect, -1, offset, len); /* 0 == memory */
> break;
> case LOC_REGISTER:
> case LOC_REGPARM:
> --- 1226,1232 ----
> DEPRECATED_SYMBOL_NAME (sym), len,
> tmp /* address */);
> }
> ! add_memrange (collect, -1, offset, len); /* -1 == memory */
> break;
> case LOC_REGISTER:
> case LOC_REGPARM:
How about introducing a macro, so that the code speaks for itself?
next prev parent reply other threads:[~2005-11-19 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-19 4:45 Jim Blandy
2005-11-19 5:26 ` Daniel Jacobowitz
2005-11-19 12:42 ` Jim Blandy
[not found] ` <437E89C1.7050104@redhat.com>
[not found] ` <8f2776cb0511182044r7a653ae5w46f3f2a1ddcaeec7@mail.gmail.com>
2005-11-19 12:43 ` Fwd: " Jim Blandy
2005-11-19 12:56 ` Eli Zaretskii [this message]
2005-11-20 5:44 ` Jim Blandy
2005-11-20 5:47 ` Eli Zaretskii
2005-11-21 5:10 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uek5chpln.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox