From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-41580-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26628 invoked by alias); 19 Nov 2005 10:57:49 -0000
Received: (qmail 26603 invoked by uid 22791); 19 Nov 2005 10:57:47 -0000
Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (192.114.186.20)     by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 19 Nov 2005 10:57:47 +0000
Received: from HOME-C4E4A596F7 (IGLD-83-130-251-47.inter.net.il [83.130.251.47]) 	by nitzan.inter.net.il (MOS 3.6.5-GR) 	with ESMTP id BZA72971 (AUTH halo1); 	Sat, 19 Nov 2005 12:57:35 +0200 (IST)
Date: Sat, 19 Nov 2005 12:56:00 -0000
Message-Id: <uek5chpln.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Blandy <jimb@red-bean.com>
CC: gdb-patches@sources.redhat.com
In-reply-to: <8f2776cb0511182045h5fe6b1a7ye0811b1bfaa74a59@mail.gmail.com> 	(message from Jim Blandy on Fri, 18 Nov 2005 20:45:28 -0800)
Subject: Re: Fwd: Obvious: doc fix for 'struct memrange' in tracepoints.c
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <8f2776cb0511181717k5b9bd035uc5ec857ea272a493@mail.gmail.com> 	 <20051119012057.GA26596@nevyn.them.org> 	 <8f2776cb0511181722h7f721b71uf4b94016e5a18da9@mail.gmail.com> 	 <437E89C1.7050104@redhat.com> 	 <8f2776cb0511182044r7a653ae5w46f3f2a1ddcaeec7@mail.gmail.com> <8f2776cb0511182045h5fe6b1a7ye0811b1bfaa74a59@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2005-11/txt/msg00363.txt.bz2

> Date: Fri, 18 Nov 2005 20:45:28 -0800
> From: Jim Blandy <jimb@red-bean.com>
> 
> *** gdb/tracepoint.c    19 Nov 2005 01:23:26 -0000      1.79
> --- gdb/tracepoint.c    19 Nov 2005 04:42:36 -0000
> *************** collect_symbol (struct collection_list *
> *** 1226,1232 ****
>                            DEPRECATED_SYMBOL_NAME (sym), len,
>                            tmp /* address */);
>         }
> !       add_memrange (collect, -1, offset, len);        /* 0 == memory */
>         break;
>       case LOC_REGISTER:
>       case LOC_REGPARM:
> --- 1226,1232 ----
>                            DEPRECATED_SYMBOL_NAME (sym), len,
>                            tmp /* address */);
>         }
> !       add_memrange (collect, -1, offset, len);        /* -1 == memory */
>         break;
>       case LOC_REGISTER:
>       case LOC_REGPARM:

How about introducing a macro, so that the code speaks for itself?