From: Eli Zaretskii <eliz@gnu.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [rfc] [17/17] Get rid of current_gdbarch in go32-nat.c
Date: Fri, 12 Oct 2007 10:56:00 -0000 [thread overview]
Message-ID: <uejg0n4al.fsf@gnu.org> (raw)
In-Reply-To: <470DE4C1.9070509@de.ibm.com> (message from Markus Deuling on Thu, 11 Oct 2007 10:54:25 +0200)
> Date: Thu, 11 Oct 2007 10:54:25 +0200
> From: Markus Deuling <deuling@de.ibm.com>
> CC: Ulrich Weigand <uweigand@de.ibm.com>
>
> this patch gets rid of some of the current_gdbarch's in go32-nat.c
> Is this ok to commit?
>
> ChangeLog:
>
>
> * go32-nat.c (fetch_register, go32_fetch_registers, store_register)
> (go32_store_registers): Use get_regcache_arch to get at the current
> architecture by regcache.
Sorry for asking this so late, but could you please explain the
reason(s) why these changes are a good idea, i.e. what potential
problem(s) are they trying to solve? If I tell you that the go32
(a.k.a. DJGPP) native build of GDB supports only a single
architecture, would those reason(s) still hold?
next prev parent reply other threads:[~2007-10-12 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 8:56 Markus Deuling
2007-10-12 10:56 ` Eli Zaretskii [this message]
2007-10-22 7:44 ` Markus Deuling
2007-10-22 20:25 ` Eli Zaretskii
2007-10-23 10:31 ` Markus Deuling
2007-10-23 21:15 ` Eli Zaretskii
2007-10-23 21:55 ` Daniel Jacobowitz
2007-10-24 4:08 ` Eli Zaretskii
2007-10-24 11:48 ` Daniel Jacobowitz
2007-10-24 19:24 ` Eli Zaretskii
2007-10-24 13:39 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uejg0n4al.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox