From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30651 invoked by alias); 12 Oct 2007 08:08:48 -0000 Received: (qmail 30643 invoked by uid 22791); 12 Oct 2007 08:08:48 -0000 X-Spam-Check-By: sourceware.org Received: from nitzan.inter.net.il (HELO nitzan.inter.net.il) (213.8.233.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Oct 2007 08:08:46 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-64-182.inter.net.il [80.230.64.182]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id HZZ02794 (AUTH halo1); Fri, 12 Oct 2007 10:05:54 +0200 (IST) Date: Fri, 12 Oct 2007 10:56:00 -0000 Message-Id: From: Eli Zaretskii To: Markus Deuling CC: gdb-patches@sourceware.org, uweigand@de.ibm.com In-reply-to: <470DE4C1.9070509@de.ibm.com> (message from Markus Deuling on Thu, 11 Oct 2007 10:54:25 +0200) Subject: Re: [rfc] [17/17] Get rid of current_gdbarch in go32-nat.c Reply-to: Eli Zaretskii References: <470DE4C1.9070509@de.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00333.txt.bz2 > Date: Thu, 11 Oct 2007 10:54:25 +0200 > From: Markus Deuling > CC: Ulrich Weigand > > this patch gets rid of some of the current_gdbarch's in go32-nat.c > Is this ok to commit? > > ChangeLog: > > > * go32-nat.c (fetch_register, go32_fetch_registers, store_register) > (go32_store_registers): Use get_regcache_arch to get at the current > architecture by regcache. Sorry for asking this so late, but could you please explain the reason(s) why these changes are a good idea, i.e. what potential problem(s) are they trying to solve? If I tell you that the go32 (a.k.a. DJGPP) native build of GDB supports only a single architecture, would those reason(s) still hold?