RFA: add linetable to "maint info symtabs" output

RFA: add linetable to "maint info symtabs" output

[Douglas Evans]

[-- Attachment #1: Type: text/plain, Size: 86 bytes --]

I've been debugging some linetable issues, and this has been useful.

Ok to check in?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gdb-071113-symmisc.patch --]
[-- Type: text/x-patch; name=gdb-071113-symmisc.patch, Size: 887 bytes --]

2007-11-13  Doug Evans  <dje@google.com>

	* symmisc.c (maintenance_info_symtabs): Print linetable info.

Index: symmisc.c
===================================================================
RCS file: /cvs/src/src/gdb/symmisc.c,v
retrieving revision 1.44
diff -u -p -r1.44 symmisc.c
--- symmisc.c	19 Oct 2007 12:26:34 -0000	1.44
+++ symmisc.c	13 Nov 2007 18:36:38 -0000
@@ -1039,6 +1039,8 @@ maintenance_info_symtabs (char *regexp, 
             printf_filtered ("    blockvector ((struct blockvector *) %p)%s\n",
                              symtab->blockvector,
                              symtab->primary ? " (primary)" : "");
+            printf_filtered ("    linetable ((struct linetable *) %p)\n",
+                             symtab->linetable);
             printf_filtered ("    debugformat %s\n", symtab->debugformat);
             printf_filtered ("  }\n");
           }

Re: RFA: add linetable to "maint info symtabs" output

[Eli Zaretskii]

> Date: Tue, 13 Nov 2007 10:58:46 -0800
> From: "Douglas Evans" <dje@google.com>
> 
> I've been debugging some linetable issues, and this has been useful.

If this is approved, please augment with the new printouts the
examples in the manual that show the output of this command.

Thanks.

Re: RFA: add linetable to "maint info symtabs" output

[Joel Brobecker]

> 2007-11-13  Doug Evans  <dje@google.com>
> 
>         * symmisc.c (maintenance_info_symtabs): Print linetable info.
>
> Ok to check in?

That looks good to me. But please remember to do the documentation
update as asked by Eli.

BTW: Do know know about -symbol-list-lines? It dumps the line table.
It was meant mostly for front-ends, but I do use it occasionally to
diagnose some problems.

Thank you,
-- 
Joel

Re: RFA: add linetable to "maint info symtabs" output

[Douglas Evans]

On Nov 13, 2007 3:13 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> > 2007-11-13  Doug Evans  <dje@google.com>
> >
> >         * symmisc.c (maintenance_info_symtabs): Print linetable info.
> >
> > Ok to check in?
>
> That looks good to me. But please remember to do the documentation
> update as asked by Eli.

Shall do, thanks.

> BTW: Do know know about -symbol-list-lines? It dumps the line table.
> It was meant mostly for front-ends, but I do use it occasionally to
> diagnose some problems.

I didn't, thanks.