Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] new set/show multiple-choice-auto-select commands
Date: Tue, 01 Jan 2008 20:16:00 -0000	[thread overview]
Message-ID: <ubq85wbec.fsf@gnu.org> (raw)
In-Reply-To: <20080101143621.GC24843@adacore.com> (message from Joel Brobecker 	on Tue, 1 Jan 2008 06:36:21 -0800)

> Date: Tue, 1 Jan 2008 06:36:21 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> 
> The user sometimes enters an expression which is ambiguous. For instance,
> the name of a function or a variable which has homonyms... In that case,
> the debugger is expected to display the list of possibilities and ask
> the user to choose which one he meant (with an additional 2 possible
> choices: "all" and "cancel").
> 
> This has been a very practical solution when in interactive mode
> (ie when a user is driving the session), but an annoyance when driving
> the debugger with a tool.

Please explain why, I'm not sure I understand.  When driving GDB with
a tool, the tool is responsible for doing TRT, so why is this a
nuisance?  And how does your solution alleviates that nuisance?

> So we added a new set/show command that
> allowed the user to configure the behavior of the debugger so that:
>   1. Either the menu is still displayed (default behavior);
>   2. The choice "all" is always automatically selected;
>   3. The choice "cancel" is always automatically selected.
> Some of the AdaCore engineers actually disliked the menu and started
> using this new command to always select all options, even in
> interactive mode.
> 
> The syntax is as follow:
> 
>         (gdb) set multiple-choice-auto-select (off|all|cancel)
>         (gdb) show multiple-choice-auto-select
> 
> As said above, the default is "off", which preserves the current
> behavior by default.

Can you please give an example of the behavior under each one of these
settings?  I'm afraid I cannot judge the suggestion without
understanding its effect on the users.

> +    error (_("\
> +canceled because the command is ambiguous and the multiple-choice menu\n\
> +has been deactivated.  See set/show multiple-choice-auto-select."));

Shouldn't "canceled" be capitalized?

> +  add_setshow_enum_cmd ("multiple-choice-auto-select", no_class,
> +                        auto_select_choices, &auto_select_choice,
> +                        _("\
> +Set the debugger behavior when part of a command is ambiguous and\n\
> +a multiple-choice menu would normally be printed."), _("\

The first line of the command's doc string should be a complete
sentence, or at least a complete phrase.  That's because some help
commands only display the first line (and stop at the first comma or
period in that line, IIRC).

Thanks.


  reply	other threads:[~2008-01-01 20:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-01 14:36 Joel Brobecker
2008-01-01 20:16 ` Eli Zaretskii [this message]
2008-01-02  4:35   ` Joel Brobecker
2008-01-05 11:03     ` Eli Zaretskii
2008-01-15  9:29     ` Markus Deuling
2008-01-15 12:37       ` Joel Brobecker
2008-01-16  7:32         ` Markus Deuling
2008-01-16 10:20           ` Joel Brobecker
2008-01-16 10:40             ` Markus Deuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubq85wbec.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox