Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Patch to limit field name completion candidates
Date: Tue, 13 May 2008 18:11:00 -0000	[thread overview]
Message-ID: <ubq3alwq8.fsf@gnu.org> (raw)
In-Reply-To: <m38wyf6py1.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 12 May 2008 17:52:06 -0600
> 
> For a long time now I've accidentally typed things like:
> 
>     p somestruct.<TAB>
> 
> ... and had to wait while gdb dumped all available symbols to gud.
> 
> It seemed to me that gdb should know that I'm trying to complete a
> field expression and limit the completions to fields actually
> occurring in the structure type on the left hand side.

Ooh, another completion junkie!  Good, I'm also hooked.

> I only updated the C parser.  This code works by modifying the lexer
> to return a special COMPLETE token in the important cases.  Note that
> it completes both "p foo.TAB" and "p foo.somethingTAB" correctly --
> the former by making an expression to a field with an empty name.

Thanks.  But what about the situation where I actually want to type

  p foo.c:bar

If I type "p foo.<TAB>", will I see "foo.c" as one of the possible
completions, after your change, whether there is or isn't also a
struct foo in the program?


  reply	other threads:[~2008-05-13  3:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 17:01 Tom Tromey
2008-05-13 18:11 ` Eli Zaretskii [this message]
2008-05-13 18:20   ` Tom Tromey
2008-05-13 18:32     ` Daniel Jacobowitz
2008-05-13 18:36       ` Tom Tromey
2008-05-13 21:00       ` Eli Zaretskii
2008-05-13 20:52     ` Eli Zaretskii
2008-06-05 17:10 ` Daniel Jacobowitz
2008-06-05 19:21   ` Tom Tromey
2008-06-05 19:30     ` Eli Zaretskii
2008-06-05 20:02       ` Tom Tromey
2008-06-06  9:47         ` Eli Zaretskii
2008-06-05 19:46     ` Daniel Jacobowitz
2008-06-05 20:03       ` Tom Tromey
2008-06-05 20:08         ` Daniel Jacobowitz
2008-06-06  0:49           ` Tom Tromey
2008-06-06  2:32             ` Daniel Jacobowitz
2008-06-06  2:41               ` Tom Tromey
2008-06-06 10:28                 ` Eli Zaretskii
2008-06-06 17:50                   ` Tom Tromey
2008-06-06 19:46                     ` Eli Zaretskii
2008-06-06 19:54                       ` Daniel Jacobowitz
2008-06-05 20:50       ` Tom Tromey
2008-06-06 10:13         ` Eli Zaretskii
2008-06-06 10:53           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ubq3alwq8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox