Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Patch to limit field name completion candidates
Date: Thu, 05 Jun 2008 20:03:00 -0000	[thread overview]
Message-ID: <m3bq2fd4zl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20080605194553.GG25085@caradoc.them.org> (Daniel Jacobowitz's message of "Thu\, 5 Jun 2008 15\:45\:53 -0400")

>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

>> We aren't parsing complete expressions, true, but I think by the time
>> the COMPLETE token is reduced, we will have reduced the entire LHS of
>> the struct op expression.  And, we throw away the rest of the
>> expression -- all the malformed parts.
>> 
>> So, I think it ought to be safe in all cases.

Daniel> Safe, yes.  That's not the failure mode I was worried about.  I'm
Daniel> wondering if we will ever error out before we reduce the COMPLETE.
Daniel> But it seems to work so far.

In that case, nothing will call mark_struct_expression, and so the
completion machinery will not attempt field name completion.

Daniel> Another example near the bottom of Command Completion would probably
Daniel> do it.

Ok.  I will add this.

Tom


  reply	other threads:[~2008-06-05 20:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 17:01 Tom Tromey
2008-05-13 18:11 ` Eli Zaretskii
2008-05-13 18:20   ` Tom Tromey
2008-05-13 18:32     ` Daniel Jacobowitz
2008-05-13 18:36       ` Tom Tromey
2008-05-13 21:00       ` Eli Zaretskii
2008-05-13 20:52     ` Eli Zaretskii
2008-06-05 17:10 ` Daniel Jacobowitz
2008-06-05 19:21   ` Tom Tromey
2008-06-05 19:30     ` Eli Zaretskii
2008-06-05 20:02       ` Tom Tromey
2008-06-06  9:47         ` Eli Zaretskii
2008-06-05 19:46     ` Daniel Jacobowitz
2008-06-05 20:03       ` Tom Tromey [this message]
2008-06-05 20:08         ` Daniel Jacobowitz
2008-06-06  0:49           ` Tom Tromey
2008-06-06  2:32             ` Daniel Jacobowitz
2008-06-06  2:41               ` Tom Tromey
2008-06-06 10:28                 ` Eli Zaretskii
2008-06-06 17:50                   ` Tom Tromey
2008-06-06 19:46                     ` Eli Zaretskii
2008-06-06 19:54                       ` Daniel Jacobowitz
2008-06-05 20:50       ` Tom Tromey
2008-06-06 10:13         ` Eli Zaretskii
2008-06-06 10:53           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bq2fd4zl.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox