Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tomas Holmberg <th@virtutech.com>
Cc: gdb-patches@sourceware.org, msnyder@vmware.com
Subject: Re: reverse for GDB/MI
Date: Wed, 17 Dec 2008 16:41:00 -0000	[thread overview]
Message-ID: <uabaug3ip.fsf@gnu.org> (raw)
In-Reply-To: <49491316.8080402@virtutech.com>

> Date: Wed, 17 Dec 2008 15:56:22 +0100
> From: Tomas Holmberg <th@virtutech.com>
> CC: gdb-patches@sourceware.org, msnyder@vmware.com
> 
> > Thanks, but please also submit a suitable change for the manual.
> Documentation for reverse MI commands attached.

Thanks.

> +(gdb)

This should be "(@value{GDBP})", not a literal "(gdb)" (here and
elsewhere in your patch).

> +beginning of the previous source line. Starting from the first line of
                                        ^^
Please make sure there are 2 spaces after a period that ends a
sentence.

Other than that, this patch is fine with me.


  reply	other threads:[~2008-12-17 16:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 10:59 Tomas Holmberg
2008-12-15 18:52 ` Marc Khouzam
2008-12-16  8:44   ` Jakob Engblom
2008-12-16 14:45     ` Marc Khouzam
2008-12-15 20:50 ` Eli Zaretskii
2008-12-17 14:57   ` Tomas Holmberg
2008-12-17 16:41     ` Eli Zaretskii [this message]
2008-12-17 16:17 ` Vladimir Prus
2008-12-18  8:33   ` Tomas Holmberg
2008-12-18  8:35     ` Vladimir Prus
2008-12-18  9:16       ` Jakob Engblom
2009-02-05  9:38         ` Vladimir Prus
2009-02-06  4:11           ` Doug Evans
2009-02-06 10:08           ` Jakob Engblom
2009-02-06 10:49             ` Vladimir Prus
2009-02-06 13:56               ` Jakob Engblom
2008-12-19  8:26       ` Tomas Holmberg
2008-12-19 11:07         ` Joel Brobecker
2008-12-19 13:22           ` Pedro Alves
2008-12-19 13:32             ` Jakob Engblom
2008-12-19 19:11         ` Michael Snyder
2008-12-22 20:27           ` Marc Khouzam
2008-12-22 21:14             ` Michael Snyder
2008-12-22 21:16               ` Marc Khouzam
2009-01-03 18:09             ` Jakob Engblom
2009-01-20 18:22               ` Marc Khouzam
2009-01-21  5:23                 ` teawater
2009-01-21 15:21                 ` Tomas Holmberg
2009-02-05 12:08                 ` Vladimir Prus
2008-12-18 21:39     ` Michael Snyder
2008-12-19  9:10       ` Tomas Holmberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uabaug3ip.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=th@virtutech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox