From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60669-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1796 invoked by alias); 17 Dec 2008 16:41:36 -0000
Received: (qmail 1788 invoked by uid 22791); 17 Dec 2008 16:41:36 -0000
X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 	tests=AWL,BARRACUDA_BRBL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout4.012.net.il (HELO mtaout4.012.net.il) (84.95.2.10)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Dec 2008 16:40:56 +0000
Received: from conversion-daemon.i_mtaout4.012.net.il by i_mtaout4.012.net.il (HyperSendmail v2004.12) id <0KC100L004XRC400@i_mtaout4.012.net.il> for gdb-patches@sourceware.org; Wed, 17 Dec 2008 18:41:36 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.241.241]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KC100JVB51BCS51@i_mtaout4.012.net.il>; Wed, 17 Dec 2008 18:41:36 +0200 (IST)
Date: Wed, 17 Dec 2008 16:41:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: reverse for GDB/MI
In-reply-to: <49491316.8080402@virtutech.com>
X-012-Sender: halo1@inter.net.il
To: Tomas Holmberg <th@virtutech.com>
Cc: gdb-patches@sourceware.org, msnyder@vmware.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uabaug3ip.fsf@gnu.org>
References: <49463870.6080302@virtutech.com> <ur649i2pi.fsf@gnu.org> <49491316.8080402@virtutech.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-12/txt/msg00315.txt.bz2

> Date: Wed, 17 Dec 2008 15:56:22 +0100
> From: Tomas Holmberg <th@virtutech.com>
> CC: gdb-patches@sourceware.org, msnyder@vmware.com
> 
> > Thanks, but please also submit a suitable change for the manual.
> Documentation for reverse MI commands attached.

Thanks.

> +(gdb)

This should be "(@value{GDBP})", not a literal "(gdb)" (here and
elsewhere in your patch).

> +beginning of the previous source line. Starting from the first line of
                                        ^^
Please make sure there are 2 spaces after a period that ends a
sentence.

Other than that, this patch is fine with me.