Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA][python] Add gdb.Value.string method.
Date: Tue, 03 Feb 2009 20:02:00 -0000	[thread overview]
Message-ID: <uab93uw54.fsf@gnu.org> (raw)
In-Reply-To: <1233669417.14735.14.camel@localhost.localdomain>

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 03 Feb 2009 11:56:57 -0200
> 
> I'm not sure if you're aware, this patch didn't get a documentation
> review/approval yet.

It's OK, but...

> > +If the optional @var{encoding} argument is given, it must be a string
> > +naming the encoding of the string in the @code{gdb.Value}.

Would every Python programmer know what kind of argument strings can
be given for @var{encoding}?  If not, perhaps a list or at least a
hint where to find such a list would be useful.

Also, perhaps this feature needs some @cindex index entries.  Please
consider that.

Otherwise, it can go in.  Thanks.


  reply	other threads:[~2009-02-03 20:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-03  2:28 Thiago Jung Bauermann
2009-02-03 13:57 ` Thiago Jung Bauermann
2009-02-03 20:02   ` Eli Zaretskii [this message]
2009-02-04 19:45     ` Tom Tromey
2009-02-05 13:19       ` Thiago Jung Bauermann
2009-02-05 20:31         ` Eli Zaretskii
2009-02-05 21:17           ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uab93uw54.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox