From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61459-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31035 invoked by alias); 3 Feb 2009 20:02:27 -0000
Received: (qmail 30954 invoked by uid 22791); 3 Feb 2009 20:02:26 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Feb 2009 20:02:22 +0000
Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KEI001009EVES00@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Tue, 03 Feb 2009 22:02:37 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.158.130]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KEI00M5BAC7E4I0@i-mtaout6.012.net.il>; Tue, 03 Feb 2009 22:02:32 +0200 (IST)
Date: Tue, 03 Feb 2009 20:02:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA][python] Add gdb.Value.string method.
In-reply-to: <1233669417.14735.14.camel@localhost.localdomain>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uab93uw54.fsf@gnu.org>
References: <1230949647.8380.145.camel@localhost.localdomain> <1233669417.14735.14.camel@localhost.localdomain>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00078.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 03 Feb 2009 11:56:57 -0200
> 
> I'm not sure if you're aware, this patch didn't get a documentation
> review/approval yet.

It's OK, but...

> > +If the optional @var{encoding} argument is given, it must be a string
> > +naming the encoding of the string in the @code{gdb.Value}.

Would every Python programmer know what kind of argument strings can
be given for @var{encoding}?  If not, perhaps a list or at least a
hint where to find such a list would be useful.

Also, perhaps this feature needs some @cindex index entries.  Please
consider that.

Otherwise, it can go in.  Thanks.