Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Enhance break command help
Date: Fri, 02 Dec 2005 08:14:00 -0000	[thread overview]
Message-ID: <u8xv3diko.fsf@gnu.org> (raw)
In-Reply-To: <438F2AC7.7070505@st.com> (message from Andrew STUBBS on Thu, 01 	Dec 2005 16:54:31 +0000)

> Date: Thu, 01 Dec 2005 16:54:31 +0000
> From: Andrew STUBBS <andrew.stubbs@st.com>
> 
> Andrew Stubbs wrote:
> > The attached patch adds more information to the on-line help for the 
> > break command. It adds a brief description how to set thread specific 
> > and conditional breakpoints.
> 
> I forgot to update the testsuite to expect the new help text.
> 
> Updated patch attached.

Okay for the breakpoint.c patch, thanks.  I have only one comment:
please remove all the "The" articles before argument names, like this:

  +LOCATION may be a line number, function name, or \"*\" and an address.\n\

instead of

  +The LOCATION may be a line number, function name, or \"*\" and an address.\n\

Also, can I ask you for a small favor?  There are other *break and
similar commands defined in breakpoint.c, whose doc strings reference
those of other commands and eventually the one you fixed.  I never
liked those references: the user shouldn't need to look up several
commands she doesn't care about to arrive at the required info.  So
could you please modify all those other doc strings to simply repeat
the arguments' description you just fixed?

Also, I see that some of those doc strings don't always leave 2 blanks
after a period that ends a sentence; please fix that as well.

Only if you have time for this, of course.  TIA


  reply	other threads:[~2005-12-02  8:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-01 12:28 Andrew STUBBS
2005-12-01 16:57 ` Andrew STUBBS
2005-12-02  8:14   ` Eli Zaretskii [this message]
2005-12-02 13:54     ` Andrew STUBBS
2005-12-02 14:59       ` Eli Zaretskii
2005-12-02 17:30         ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u8xv3diko.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrew.stubbs@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox