From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21963 invoked by alias); 2 Dec 2005 08:12:17 -0000 Received: (qmail 21954 invoked by uid 22791); 2 Dec 2005 08:12:16 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Dec 2005 08:12:15 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-89-144.inter.net.il [80.230.89.144]) by romy.inter.net.il (MOS 3.7.2-GA) with ESMTP id DCG90960 (AUTH halo1); Fri, 2 Dec 2005 10:11:34 +0200 (IST) Date: Fri, 02 Dec 2005 08:14:00 -0000 Message-Id: From: Eli Zaretskii To: Andrew STUBBS CC: gdb-patches@sources.redhat.com In-reply-to: <438F2AC7.7070505@st.com> (message from Andrew STUBBS on Thu, 01 Dec 2005 16:54:31 +0000) Subject: Re: [PATCH] Enhance break command help Reply-to: Eli Zaretskii References: <438EEBC5.8040802@st.com> <438F2AC7.7070505@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00041.txt.bz2 > Date: Thu, 01 Dec 2005 16:54:31 +0000 > From: Andrew STUBBS > > Andrew Stubbs wrote: > > The attached patch adds more information to the on-line help for the > > break command. It adds a brief description how to set thread specific > > and conditional breakpoints. > > I forgot to update the testsuite to expect the new help text. > > Updated patch attached. Okay for the breakpoint.c patch, thanks. I have only one comment: please remove all the "The" articles before argument names, like this: +LOCATION may be a line number, function name, or \"*\" and an address.\n\ instead of +The LOCATION may be a line number, function name, or \"*\" and an address.\n\ Also, can I ask you for a small favor? There are other *break and similar commands defined in breakpoint.c, whose doc strings reference those of other commands and eventually the one you fixed. I never liked those references: the user shouldn't need to look up several commands she doesn't care about to arrive at the required info. So could you please modify all those other doc strings to simply repeat the arguments' description you just fixed? Also, I see that some of those doc strings don't always leave 2 blanks after a period that ends a sentence; please fix that as well. Only if you have time for this, of course. TIA