Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: drow@false.org, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Implement *running.
Date: Sun, 04 May 2008 19:50:00 -0000	[thread overview]
Message-ID: <u8wypx6d0.fsf@gnu.org> (raw)
In-Reply-To: <200805041837.44909.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sun, 4 May 2008 18:37:43 +0400
> Cc: gdb-patches@sources.redhat.com
> 
> I've added the docs. Eli, are those OK?

Thanks.  Yes, it's okay, except for a couple of comments:

> +@item *running,thread-id="@var{thread}"
> +The target is now running.  The @var{thread} field tells which
> +specific thread is now running, and can be @samp{all} if all threads
> +are running.  The frontend should assume that no interaction with a
> +running thread is possible after this notification is produced.
> +@value{GDBN} may emit this notification several times for a given
> +thread, and the frontend should handle this gracefully.

The last sentence begs a question: why would this notification emitted
more than once, and what do you mean by "gracefully"? just that it
shouldn't assume the notification is emitted only once?

> +@deftypefun void target_resumed (ptid_t @var{ptid})
> +The target was resumed.  The @var{ptid} parameter specifies which
> +thread was resume
              ^^^^^^
"resumed".

>                   , and may be RESUME_ALL if all threads are resumed.

"RESUME_ALL" should be in @code, since it's a C symbol.

Thanks.


  reply	other threads:[~2008-05-04 18:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 13:36 Vladimir Prus
2008-05-02  9:57 ` Eli Zaretskii
2008-05-02 15:59 ` Daniel Jacobowitz
2008-05-04 16:33   ` Vladimir Prus
2008-05-04 19:50     ` Eli Zaretskii [this message]
2008-05-11 15:32       ` Vladimir Prus
2008-05-11 21:46         ` Eli Zaretskii
2008-05-27 19:07     ` Vladimir Prus
2008-06-05 15:50       ` Daniel Jacobowitz
2008-06-10 12:43         ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u8wypx6d0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox