From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20899 invoked by alias); 4 May 2008 18:38:40 -0000 Received: (qmail 20891 invoked by uid 22791); 4 May 2008 18:38:40 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 04 May 2008 18:38:21 +0000 Received: from HOME-C4E4A596F7 ([84.229.228.217]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K0C004WXXR82OT4@i_mtaout5.012.net.il> for gdb-patches@sources.redhat.com; Sun, 04 May 2008 21:52:21 +0300 (IDT) Date: Sun, 04 May 2008 19:50:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Implement *running. In-reply-to: <200805041837.44909.vladimir@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Vladimir Prus Cc: drow@false.org, gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: References: <200805011735.52447.vladimir@codesourcery.com> <20080502155719.GT29202@caradoc.them.org> <200805041837.44909.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00181.txt.bz2 > From: Vladimir Prus > Date: Sun, 4 May 2008 18:37:43 +0400 > Cc: gdb-patches@sources.redhat.com > > I've added the docs. Eli, are those OK? Thanks. Yes, it's okay, except for a couple of comments: > +@item *running,thread-id="@var{thread}" > +The target is now running. The @var{thread} field tells which > +specific thread is now running, and can be @samp{all} if all threads > +are running. The frontend should assume that no interaction with a > +running thread is possible after this notification is produced. > +@value{GDBN} may emit this notification several times for a given > +thread, and the frontend should handle this gracefully. The last sentence begs a question: why would this notification emitted more than once, and what do you mean by "gracefully"? just that it shouldn't assume the notification is emitted only once? > +@deftypefun void target_resumed (ptid_t @var{ptid}) > +The target was resumed. The @var{ptid} parameter specifies which > +thread was resume ^^^^^^ "resumed". > , and may be RESUME_ALL if all threads are resumed. "RESUME_ALL" should be in @code, since it's a C symbol. Thanks.