[patch] x86-64 ptrace() ABI change sync

[patch] x86-64 ptrace() ABI change sync

[Michal Ludvig]

Hi all,
I've committed this obvious patch which synces gdb with changed glibc to 
both mainline and 5.2-branch.

Michal Ludvig

Index: ChangeLog
	* x86-64-linux-nat.c (child_xfer_memory): x86-64 ptrace() ABI
	change sync

Index: x86-64-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v
retrieving revision 1.7
diff -c -3 -p -r1.7 x86-64-linux-nat.c
*** x86-64-linux-nat.c  2002/03/27 10:21:26     1.7
--- x86-64-linux-nat.c  2002/04/04 13:01:24
*************** child_xfer_memory (CORE_ADDR memaddr, ch
*** 441,456 ****
         if (addr != memaddr || len < (int) sizeof (PTRACE_XFER_TYPE))
         {
           /* Need part of initial word -- fetch it.  */
!         ptrace (PT_READ_I, PIDGET (inferior_ptid),
!                 (PTRACE_ARG3_TYPE) addr, buffer);
         }

         if (count > 1)          /* FIXME, avoid if even boundary */
         {
!         ptrace (PT_READ_I, PIDGET (inferior_ptid),
                   ((PTRACE_ARG3_TYPE)
                    (addr + (count - 1) * sizeof (PTRACE_XFER_TYPE))),
!                 buffer + count - 1);
         }

         /* Copy data to be written over corresponding part of buffer */
--- 441,456 ----
         if (addr != memaddr || len < (int) sizeof (PTRACE_XFER_TYPE))
         {
           /* Need part of initial word -- fetch it.  */
!         buffer[0] = ptrace (PT_READ_I, PIDGET (inferior_ptid),
!                 (PTRACE_ARG3_TYPE) addr, 0);
         }

         if (count > 1)          /* FIXME, avoid if even boundary */
         {
!         buffer[count-1] = ptrace (PT_READ_I, PIDGET (inferior_ptid),
                   ((PTRACE_ARG3_TYPE)
                    (addr + (count - 1) * sizeof (PTRACE_XFER_TYPE))),
!                  0);
         }

         /* Copy data to be written over corresponding part of buffer */
*************** child_xfer_memory (CORE_ADDR memaddr, ch
*** 486,493 ****
         for (i = 0; i < count; i++, addr += sizeof (PTRACE_XFER_TYPE))
         {
           errno = 0;
!         ptrace (PT_READ_I, PIDGET (inferior_ptid),
!                 (PTRACE_ARG3_TYPE) addr, buffer + i);
           if (errno)
             return 0;
         }
--- 486,493 ----
         for (i = 0; i < count; i++, addr += sizeof (PTRACE_XFER_TYPE))
         {
           errno = 0;
!         buffer[i] = ptrace (PT_READ_I, PIDGET (inferior_ptid),
!                 (PTRACE_ARG3_TYPE) addr, 0);
           if (errno)
             return 0;
         }

Re: [patch] x86-64 ptrace() ABI change sync

[Daniel Jacobowitz]

On Thu, Apr 04, 2002 at 03:13:22PM +0200, Michal Ludvig wrote:
> Hi all,
> I've committed this obvious patch which synces gdb with changed glibc to 
> both mainline and 5.2-branch.
> 
> Michal Ludvig
> 
> Index: ChangeLog
> 	* x86-64-linux-nat.c (child_xfer_memory): x86-64 ptrace() ABI
> 	change sync

Is this needed for gdbserver?  I'd guess not, since I assumed that
ptrace() behaved according to its man page.  So probably gdbserver is
already correct.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [patch] x86-64 ptrace() ABI change sync

[Andreas Jaeger]

Daniel Jacobowitz <drow@mvista.com> writes:

> On Thu, Apr 04, 2002 at 03:13:22PM +0200, Michal Ludvig wrote:
>> Hi all,
>> I've committed this obvious patch which synces gdb with changed glibc to 
>> both mainline and 5.2-branch.
>> 
>> Michal Ludvig
>> 
>> Index: ChangeLog
>> 	* x86-64-linux-nat.c (child_xfer_memory): x86-64 ptrace() ABI
>> 	change sync
>
> Is this needed for gdbserver?  I'd guess not, since I assumed that
> ptrace() behaved according to its man page.  So probably gdbserver is
> already correct.

If you followed the man page, everything should be fine.  The problem
was that I didn't follow the man page in implemting ptrace in glibc
for x86-64 - and fixing this meant changing the interface...  ptrace
is now using the same interface for x86-64 as for x86,

Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj