Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@elta.co.il>
To: Jason Molenda <jmolenda@apple.com>
Cc: fedor@gnu.org, gdb-patches@sources.redhat.com
Subject: Re: RFA/doc: couple of small Obj-C documentation tweaks
Date: Wed, 07 Jan 2004 06:20:00 -0000	[thread overview]
Message-ID: <u65fob7no.fsf@elta.co.il> (raw)
In-Reply-To: <9E0EDFCC-40B1-11D8-B832-000393D457E2@apple.com> (message from Jason Molenda on Tue, 6 Jan 2004 17:34:21 -0800)

> From: Jason Molenda <jmolenda@apple.com>
> Date: Tue, 6 Jan 2004 17:34:21 -0800
> 
> I was looking at the gdb docs today and saw a couple of small problems
> with the Objective-C section.  OK to commit?

Yes, but please correct the following small gotchas while at that:

> @@ -8532,12 +8532,12 @@ print -[object hash]
>  @end smallexample
>  
>  @cindex print an Objective-C object description
> -will tell gdb to send the -hash message to object and print the
> +will tell gdb to send the @code{hash} message to @code{object} and print the

Instead of "gdb" we use "@value{GDBN}" in the manual (so that the
actual name that appears in the produced docs can be changed globally
with a single simple change to the value of GDBN defined at the
beginning of gdb.texinfo).

Also, I'd use @var{object} instead of @code, since "object" is a
placeholder, not a literal string (right?).  "object" in the @example
should also appear in @var.

>  result. Also an additional command has been added, @code{print-object}

There's a comma missing after "Also".  print-object and po need a
@kindex entry, since we index all the GDB commands.

>  or @code{po} for short, which is meant to print the description of an
>  object. However, this command may only work with certain Objective-C
> -libraries that have a particular hook function, called
> -@code{_NSPrintForDebugger} defined.
> +libraries that have a particular hook function,
> +@code{_NSPrintForDebugger}, defined.

I'd also add an index entry for _NSPrintForDebugger here, since
someone, some day might need to look it up.

Finally, it looks like each period that ends a sentence in this
section isn't followed by 2 spaces, as required by the GNU standards.
Could you please fix that as well?

Thanks!


  parent reply	other threads:[~2004-01-07  6:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-07  1:34 Jason Molenda
2004-01-07  4:12 ` Adam Fedor
2004-01-07  6:20 ` Eli Zaretskii [this message]
2004-01-07 23:57   ` Jason Molenda
2004-01-08 16:42     ` Eli Zaretskii
2004-01-08 22:48       ` [Committed] " Jason Molenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u65fob7no.fsf@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=fedor@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jmolenda@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox