From: Eli Zaretskii <eliz@elta.co.il>
To: Jason Molenda <jmolenda@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA/doc: couple of small Obj-C documentation tweaks
Date: Thu, 08 Jan 2004 16:42:00 -0000 [thread overview]
Message-ID: <u4qv65yu3.fsf@elta.co.il> (raw)
In-Reply-To: <44249748-416D-11D8-9715-000393D457E2@apple.com> (message from Jason Molenda on Wed, 7 Jan 2004 15:57:35 -0800)
> From: Jason Molenda <jmolenda@apple.com>
> Date: Wed, 7 Jan 2004 15:57:35 -0800
>
> Thanks for spotting the additional corrections. I'm inexperienced with
> texinfo so I want to run the patch past you before I commit.
Sure, feel free.
> makeinfo and texi2html don't give any warnings when processing this
> - I believe it to be correct.
The patch is okay, except for the following two very minor problems:
> +@kindex _NSPrintForDebugger
_NSPrintForDebugger is not a command, so @kindex isn't right here.
I'd suggest something like this:
@cindex @code{_NSPrintForDebugger}, and printing Objective-C objects
> +The print command has also been extended to accept methods. For example:
>
> @smallexample
> -print -[object hash]
> +print -[@var{object} hash]
> @end smallexample
>
> @cindex print an Objective-C object description
> -will tell gdb to send the -hash message to object and print the
> -result. Also an additional command has been added, @code{print-object}
> -or @code{po} for short, which is meant to print the description of an
> -object. However, this command may only work with certain Objective-C
> -libraries that have a particular hook function, called
> -@code{_NSPrintForDebugger} defined.
> +will tell @value{GDBN} to send the @code{hash} message to @var{object}
This last line doesn't start a new paragraph, so you need a @noindent
(alone on a separate line) immediately before it, like this:
@smallexample
print -[@var{object} hash]
@end smallexample
@cindex print an Objective-C object description
@noindent
will tell @value{GDBN} to send the @code{hash} message to @var{object}
This is needed to prevent makeinfo and TeX from indenting the line as
if it were a beginning of a paragraph. (Sorry for not catching this
when I first read the patch.)
Otherwise, please commit the patch. Thanks.
next prev parent reply other threads:[~2004-01-08 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 1:34 Jason Molenda
2004-01-07 4:12 ` Adam Fedor
2004-01-07 6:20 ` Eli Zaretskii
2004-01-07 23:57 ` Jason Molenda
2004-01-08 16:42 ` Eli Zaretskii [this message]
2004-01-08 22:48 ` [Committed] " Jason Molenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u4qv65yu3.fsf@elta.co.il \
--to=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=jmolenda@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox