From: Eli Zaretskii <eliz@gnu.org>
To: "Kaveh R. Ghazi" <ghazi@caipclassic.rutgers.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: add format attributes to gdb
Date: Fri, 29 Jul 2005 14:08:00 -0000 [thread overview]
Message-ID: <u3bpx66yx.fsf@gnu.org> (raw)
In-Reply-To: <200507282305.j6SN5Hhr017745@caipclassic.rutgers.edu> (ghazi@caipclassic.rutgers.edu)
> Date: Thu, 28 Jul 2005 19:05:17 -0400 (EDT)
> From: "Kaveh R. Ghazi" <ghazi@caipclassic.rutgers.edu>
> Cc: gdb-patches@sources.redhat.com
>
> > > 2005-07-27 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> > >
> > > * cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add
> > > ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF.
> > > * complaints.c (vcomplaint): Likewise.
> > > * defs.h (xvasprintf, xstrvprintf, verror, vfatal,
> > > internal_verror, internal_vwarning, vwarning,
> > > deprecated_query_hook, deprecated_warning_hook,
> > > deprecated_readline_begin_hook): Likewise.
> >
> > Nitpicking: these multi-line entries are not according to the GNU
> > coding standards (which specify that each line must end with a right
> > paren).
>
>
> Ok now?
>
> 2005-07-27 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add
> ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF.
> * complaints.c (vcomplaint): Likewise.
> * defs.h (xvasprintf, xstrvprintf, verror, vfatal)
> (internal_verror, internal_vwarning, vwarning)
> (deprecated_query_hook, deprecated_warning_hook)
> (deprecated_readline_begin_hook): Likewise.
> * disasm.c (fprintf_disasm): Likewise.
> * exceptions.c (throw_it): Likewise.
> * exceptions.h (throw_verror, throw_vfatal): Likewise.
> * mi/mi-interp.c (mi_interp_query_hook): Likewise.
> * mi/mi-out.c (mi_field_fmt, mi_message): Likewise.
> * tui/tui-hooks.c (tui_query_hook): Likewise.
> * tui/tui-out.c (tui_field_fmt, tui_message, out_field_fmt):
> Likewise.
> * ui-out.c (default_field_fmt, default_message, uo_field_fmt)
> (uo_message): Likewise.
> * ui-out.h (ui_out_field_fmt, ui_out_message, field_fmt_ftype)
> (message_ftype): Likewise.
> * utils.c (vfprintf_maybe_filtered, internal_vproblem)
> (defaulted_query, printchar): Likewise.
>
> gdbserver:
> * server.h (error, fatal, warning): Add ATTR_FORMAT.
Perfect. Thanks!
next prev parent reply other threads:[~2005-07-29 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu>
2005-07-28 19:07 ` Eli Zaretskii
2005-07-28 23:05 ` Kaveh R. Ghazi
2005-07-29 14:08 ` Eli Zaretskii [this message]
2005-07-29 14:12 ` Daniel Jacobowitz
2005-07-29 17:11 ` Kaveh R. Ghazi
2005-07-31 20:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u3bpx66yx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghazi@caipclassic.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox