From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40387-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 5952 invoked by alias); 29 Jul 2005 14:08:10 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5661 invoked by uid 22791); 29 Jul 2005 14:08:01 -0000
Received: from legolas.inter.net.il (HELO legolas.inter.net.il) (192.114.186.24)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 29 Jul 2005 14:08:01 +0000
Received: from HOME-C4E4A596F7 (IGLD-83-130-250-73.inter.net.il [83.130.250.73])
	by legolas.inter.net.il (MOS 3.5.8-GR)
	with ESMTP id FAB37225 (AUTH halo1);
	Fri, 29 Jul 2005 17:07:50 +0300 (IDT)
Date: Fri, 29 Jul 2005 14:08:00 -0000
Message-Id: <u3bpx66yx.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: "Kaveh R. Ghazi" <ghazi@caipclassic.rutgers.edu>
CC: gdb-patches@sources.redhat.com
In-reply-to: <200507282305.j6SN5Hhr017745@caipclassic.rutgers.edu>
	(ghazi@caipclassic.rutgers.edu)
Subject: Re: PATCH: add format attributes to gdb
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu> <uvf2usqal.fsf@gnu.org> <200507282305.j6SN5Hhr017745@caipclassic.rutgers.edu>
X-SW-Source: 2005-07/txt/msg00225.txt.bz2

> Date: Thu, 28 Jul 2005 19:05:17 -0400 (EDT)
> From: "Kaveh R. Ghazi" <ghazi@caipclassic.rutgers.edu>
> Cc: gdb-patches@sources.redhat.com
> 
>  > > 2005-07-27  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
>  > > 
>  > >	* cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add
>  > >	ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF.
>  > >	* complaints.c (vcomplaint): Likewise.
>  > >	* defs.h (xvasprintf, xstrvprintf, verror, vfatal,
>  > >	internal_verror, internal_vwarning, vwarning,
>  > >	deprecated_query_hook, deprecated_warning_hook,
>  > >	deprecated_readline_begin_hook): Likewise.
>  > 
>  > Nitpicking: these multi-line entries are not according to the GNU
>  > coding standards (which specify that each line must end with a right
>  > paren).
> 
> 
> Ok now?
> 
> 2005-07-27  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
> 
> 	* cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add
> 	ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF.
> 	* complaints.c (vcomplaint): Likewise.
> 	* defs.h (xvasprintf, xstrvprintf, verror, vfatal)
> 	(internal_verror, internal_vwarning, vwarning)
> 	(deprecated_query_hook, deprecated_warning_hook)
> 	(deprecated_readline_begin_hook): Likewise.
> 	* disasm.c (fprintf_disasm): Likewise.
> 	* exceptions.c (throw_it): Likewise.
> 	* exceptions.h (throw_verror, throw_vfatal): Likewise.
> 	* mi/mi-interp.c (mi_interp_query_hook): Likewise.
> 	* mi/mi-out.c (mi_field_fmt, mi_message): Likewise.
> 	* tui/tui-hooks.c (tui_query_hook): Likewise.
> 	* tui/tui-out.c (tui_field_fmt, tui_message, out_field_fmt):
> 	Likewise.
> 	* ui-out.c (default_field_fmt, default_message, uo_field_fmt)
> 	(uo_message): Likewise.
> 	* ui-out.h (ui_out_field_fmt, ui_out_message, field_fmt_ftype)
> 	(message_ftype): Likewise.
> 	* utils.c (vfprintf_maybe_filtered, internal_vproblem)
> 	(defaulted_query, printchar): Likewise.
> 	
> gdbserver:
> 	* server.h (error, fatal, warning): Add ATTR_FORMAT.

Perfect.  Thanks!