From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: nickrob@snap.net.nz, gdb-patches@sources.redhat.com
Subject: Re: -stack-list-frames HIGH_FRAME changes
Date: Fri, 08 Sep 2006 16:37:00 -0000 [thread overview]
Message-ID: <u1wqmwbzv.fsf@gnu.org> (raw)
In-Reply-To: <200609081027.50966.ghost@cs.msu.su> (message from Vladimir Prus on Fri, 8 Sep 2006 10:27:50 +0400)
> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Fri, 8 Sep 2006 10:27:50 +0400
> Cc: gdb-patches@sources.redhat.com
>
> ./Changelog:
> 2006-05-05 Vladimir Prus <ghost@lvk.cs.msu.su>
>
> * mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Don't emit error
> if high requested frame number is larger then number of available
> frames. ^^^^
>
>
> doc/ChangeLog
> 2006-05-05 Vladimir Prus <ghost@lvk.cs.msu.su>
>
> * gdb.texinfo (GDB/MI Stack Manipulation): Mention that
> -stack-list-arguments HIGH_FRAME argument can be larger then the
> actual number of frames. ^^^^
You mean "than", not "then".
> Display a list of the arguments for the frames between @var{low-frame}
> and @var{high-frame} (inclusive). If @var{low-frame} and
> -@var{high-frame} are not provided, list the arguments for the whole call
> -stack.
> +@var{high-frame} are not provided, list the arguments for the whole
> +call stack. If the two arguments are equal, it shows the single frame
^^
Two spaces, please.
Also, ``it shows'' is not in line with the style of the rest of the
description; ``show'' is better:
If the two arguments are equal, show the single frame at the
given level.
> +larger than the actual number of frames. On the other hand,
> +@var{high-frame} may be larger then the actual number of frames, in
^^^^
"than".
With these fixes, you have green light to commit the patch. Thanks!
next prev parent reply other threads:[~2006-09-08 16:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 22:37 Nick Roberts
2006-09-07 23:10 ` Daniel Jacobowitz
2006-09-08 6:28 ` Vladimir Prus
2006-09-08 8:30 ` Nick Roberts
2006-09-08 8:39 ` Vladimir Prus
2006-09-08 14:33 ` Daniel Jacobowitz
2006-09-08 16:37 ` Eli Zaretskii [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-05 7:54 Vladimir Prus
2006-05-05 10:30 ` Eli Zaretskii
2006-05-05 13:51 ` Daniel Jacobowitz
2006-05-05 14:39 ` Vladimir Prus
2006-05-05 14:53 ` Daniel Jacobowitz
2006-05-05 19:20 ` Jim Blandy
2006-05-05 15:46 ` Bob Rossi
2006-05-05 14:52 ` Daniel Jacobowitz
2006-09-07 16:10 ` Daniel Jacobowitz
2006-09-07 16:41 ` Vladimir Prus
2006-05-05 21:13 ` Eli Zaretskii
2006-09-07 16:10 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u1wqmwbzv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox