From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27744 invoked by alias); 8 Sep 2006 16:37:40 -0000 Received: (qmail 27735 invoked by uid 22791); 8 Sep 2006 16:37:39 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (192.114.186.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Sep 2006 16:37:33 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-22-149.inter.net.il [80.230.22.149]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id AKK84490 (AUTH halo1); Fri, 8 Sep 2006 19:37:24 +0300 (IDT) Date: Fri, 08 Sep 2006 16:37:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: nickrob@snap.net.nz, gdb-patches@sources.redhat.com In-reply-to: <200609081027.50966.ghost@cs.msu.su> (message from Vladimir Prus on Fri, 8 Sep 2006 10:27:50 +0400) Subject: Re: -stack-list-frames HIGH_FRAME changes Reply-to: Eli Zaretskii References: <17664.40625.696162.335382@kahikatea.snap.net.nz> <200609081027.50966.ghost@cs.msu.su> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00041.txt.bz2 > From: Vladimir Prus > Date: Fri, 8 Sep 2006 10:27:50 +0400 > Cc: gdb-patches@sources.redhat.com > > ./Changelog: > 2006-05-05 Vladimir Prus > > * mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Don't emit error > if high requested frame number is larger then number of available > frames. ^^^^ > > > doc/ChangeLog > 2006-05-05 Vladimir Prus > > * gdb.texinfo (GDB/MI Stack Manipulation): Mention that > -stack-list-arguments HIGH_FRAME argument can be larger then the > actual number of frames. ^^^^ You mean "than", not "then". > Display a list of the arguments for the frames between @var{low-frame} > and @var{high-frame} (inclusive). If @var{low-frame} and > -@var{high-frame} are not provided, list the arguments for the whole call > -stack. > +@var{high-frame} are not provided, list the arguments for the whole > +call stack. If the two arguments are equal, it shows the single frame ^^ Two spaces, please. Also, ``it shows'' is not in line with the style of the rest of the description; ``show'' is better: If the two arguments are equal, show the single frame at the given level. > +larger than the actual number of frames. On the other hand, > +@var{high-frame} may be larger then the actual number of frames, in ^^^^ "than". With these fixes, you have green light to commit the patch. Thanks!