From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: vladimir@codesourcery.com, gdb-patches@sources.redhat.com
Subject: Re: [ob] fix mingw compilation
Date: Fri, 09 Feb 2007 15:27:00 -0000 [thread overview]
Message-ID: <u1wkzbbcu.fsf@gnu.org> (raw)
In-Reply-To: <20070208162512.GB11806@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 8 Feb 2007 11:25:12 -0500)
> Date: Thu, 8 Feb 2007 11:25:12 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Vladimir Prus <vladimir@codesourcery.com>,
> gdb-patches@sources.redhat.com
>
> > > - HANDLE pipeline_out = (HANDLE) _get_osfhandle (scb->fd);
> > > + HANDLE pipeline_out;
> >
> > This one-line change is unnecessary; please put back the original
> > code, it's perfectly valid C, and shouldn't trigger any warnings or
> > errors from GCC.
>
> It's valid either way, of course.
Sure, but I don't like unnecessary changes.
> In the interests of all getting along, I checked this in (to get the
> message out of my todo queue :-).
Thanks!
prev parent reply other threads:[~2007-02-09 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 10:37 Vladimir Prus
2007-01-30 20:24 ` Eli Zaretskii
2007-02-08 16:25 ` Daniel Jacobowitz
2007-02-09 15:27 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u1wkzbbcu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox