From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2585 invoked by alias); 9 Feb 2007 15:27:07 -0000 Received: (qmail 2565 invoked by uid 22791); 9 Feb 2007 15:27:05 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 15:26:59 +0000 Received: from HOME-C4E4A596F7 (IGLD-83-130-217-134.inter.net.il [83.130.217.134]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id BVN03729 (AUTH halo1); Fri, 9 Feb 2007 17:26:49 +0200 (IST) Date: Fri, 09 Feb 2007 15:27:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: vladimir@codesourcery.com, gdb-patches@sources.redhat.com In-reply-to: <20070208162512.GB11806@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 8 Feb 2007 11:25:12 -0500) Subject: Re: [ob] fix mingw compilation Reply-to: Eli Zaretskii References: <200701301337.14436.vladimir@codesourcery.com> <20070208162512.GB11806@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00123.txt.bz2 > Date: Thu, 8 Feb 2007 11:25:12 -0500 > From: Daniel Jacobowitz > Cc: Vladimir Prus , > gdb-patches@sources.redhat.com > > > > - HANDLE pipeline_out = (HANDLE) _get_osfhandle (scb->fd); > > > + HANDLE pipeline_out; > > > > This one-line change is unnecessary; please put back the original > > code, it's perfectly valid C, and shouldn't trigger any warnings or > > errors from GCC. > > It's valid either way, of course. Sure, but I don't like unnecessary changes. > In the interests of all getting along, I checked this in (to get the > message out of my todo queue :-). Thanks!