From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] 09/10 Add "continue --all"
Date: Thu, 08 May 2008 18:29:00 -0000 [thread overview]
Message-ID: <u1w4dnhs4.fsf@gnu.org> (raw)
In-Reply-To: <200805061649.50105.pedro@codesourcery.com>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 6 May 2008 16:49:50 +0100
>
> + if (args != NULL)
> + {
> + if (strncmp (args, "--all", 5) == 0)
Can we please void literal constants like 5 here? sizeof should be
our friend, and you actually use it 3 lines below this:
> + {
> + all_threads = 1;
> + args += sizeof ("--all") - 1;
> + if (*args == '\0')
> + args = NULL;
> + }
next prev parent reply other threads:[~2008-05-08 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 18:12 Pedro Alves
2008-05-07 11:58 ` Pierre Muller
2008-05-07 19:36 ` Pedro Alves
2008-05-08 18:29 ` Eli Zaretskii [this message]
2008-05-09 2:35 ` Pedro Alves
2008-05-09 3:08 ` Daniel Jacobowitz
2008-05-09 3:54 ` Pedro Alves
2008-05-09 17:07 ` Pedro Alves
2008-05-09 19:08 ` Daniel Jacobowitz
2008-05-09 19:20 ` Andrew STUBBS
2008-05-11 20:34 ` Joel Brobecker
2008-05-19 17:07 ` Pedro Alves
2008-05-19 21:29 ` Michael Snyder
2008-05-19 21:55 ` Daniel Jacobowitz
2008-05-19 22:46 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u1w4dnhs4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox