From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-55878-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15864 invoked by alias); 8 May 2008 11:43:48 -0000
Received: (qmail 15855 invoked by uid 22791); 8 May 2008 11:43:47 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 May 2008 11:43:28 +0000
Received: from HOME-C4E4A596F7 ([83.130.255.47]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K0J005JFT7GEAM0@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Thu, 08 May 2008 14:57:17 +0300 (IDT)
Date: Thu, 08 May 2008 18:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] 09/10 Add "continue --all"
In-reply-to: <200805061649.50105.pedro@codesourcery.com>
X-012-Sender: halo1@inter.net.il
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <u1w4dnhs4.fsf@gnu.org>
Content-transfer-encoding: 7BIT
References: <200805061649.50105.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-05/txt/msg00279.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 6 May 2008 16:49:50 +0100
> 
> +  if (args != NULL)
> +    {
> +      if (strncmp (args, "--all", 5) == 0)

Can we please void literal constants like 5 here?  sizeof should be
our friend, and you actually use it 3 lines below this:

> +	{
> +	  all_threads = 1;
> +	  args += sizeof ("--all") - 1;
> +	  if (*args == '\0')
> +	    args = NULL;
> +	}