Top-level configure.in patch

Top-level configure.in patch

[Ben Elliston]

The ChangeLog entry for this patch ought to provide sufficient
explanation.  I have tested this with a wide variety of shells.  Okay
to commit?

2001-09-19  Ben Elliston  <bje@redhat.com>

	* configure.in (sparc-sun-solaris2*): Don't use /usr/bin/which on
	Solaris when testing for the /usr/ucb/cc compiler; it has incorrect
	semantics.  Use the shell built-in "type" command instead.

Index: configure.in
===================================================================
RCS file: /cvs/cvsfiles/devo/configure.in,v
retrieving revision 1.728
diff -u -c -r1.728 configure.in
*** configure.in	2001/09/13 13:28:37	1.728
--- configure.in	2001/09/19 03:53:16
***************
*** 1506,1512 ****
  case "${host}" in
    sparc-sun-solaris2*)
        CCBASE="`echo ${CC-cc} | sed 's/ .*$//'`"
!       if [ "`/usr/bin/which $CCBASE`" = "/usr/ucb/cc" ] ; then
            could_use=
            [ -d /opt/SUNWspro/bin ] && could_use="/opt/SUNWspro/bin"
            if [ -d /opt/cygnus/bin ] ; then
--- 1506,1512 ----
  case "${host}" in
    sparc-sun-solaris2*)
        CCBASE="`echo ${CC-cc} | sed 's/ .*$//'`"
!       if [ "`type $CCBASE | sed 's/^[^/]*//'`" = "/usr/ucb/cc" ] ; then
            could_use=
            [ -d /opt/SUNWspro/bin ] && could_use="/opt/SUNWspro/bin"
            if [ -d /opt/cygnus/bin ] ; then

Re: Top-level configure.in patch

[Ian Lance Taylor]

Ben Elliston <bje@redhat.com> writes:

> The ChangeLog entry for this patch ought to provide sufficient
> explanation.  I have tested this with a wide variety of shells.  Okay
> to commit?

Old shells don't support the type builtin.  However, since this code
is only run on a Solaris host, I think it's fine.  I doubt anybody
will do a Canadian Cross from a very old system to a Solaris host.

Ian

Re: Top-level configure.in patch

[Ben Elliston]

>>>>> "Ian" == Ian Lance Taylor <ian@airs.com> writes:

  Ian> Old shells don't support the type builtin.  However, since this code
  Ian> is only run on a Solaris host, I think it's fine.  I doubt anybody
  Ian> will do a Canadian Cross from a very old system to a Solaris host.

The existing code (using /usr/bin/which) doesn't do much better on
Solaris systems whereby the user has a strange .cshrc that interacts
badly with the which script.  If you read the Solaris man page for
which(1), it doesn't even behave the way that configure.in expects it
to.  Either way, someone loses.  My change hopefully leads to least
loss.  ;-)

Thanks--I'll check it in.

Ben

top-level configure.in patch

[Ben Elliston]

This follow-up patch stops configure from generating a "cgen" build
directory, as it's no longer needed.  Okay to commit?

2002-06-24  Ben Elliston  <bje@redhat.com>

	* configure.in (host_tools): Remove cgen.

Index: configure.in
===================================================================
RCS file: /cvs/src/src/configure.in,v
retrieving revision 1.89
diff -u -p -c -r1.89 configure.in
*** configure.in	21 Jun 2002 22:20:17 -0000	1.89
--- configure.in	24 Jun 2002 15:06:38 -0000
*************** libstdcxx_version="target-libstdc++-v3"
*** 49,55 ****
  # these tools are built for the host environment
  # Note, the powerpc-eabi build depends on sim occurring before gdb in order to
  # know that we are building the simulator.
! host_tools="texinfo byacc flex bison binutils ld gas gcc cgen sid sim gdb make patch prms send-pr gprof gdbtest tgas etc expect dejagnu ash bash bzip2 m4 autoconf automake libtool ispell grep diff rcs cvssrc fileutils shellutils time textutils wdiff find uudecode hello tar gzip indent recode release sed utils guile perl apache inet gawk findutils snavigator libtool gettext zip fastjar"
  
  # libgcj represents the runtime libraries only used by gcj.
  libgcj="target-libffi \
--- 49,55 ----
  # these tools are built for the host environment
  # Note, the powerpc-eabi build depends on sim occurring before gdb in order to
  # know that we are building the simulator.
! host_tools="texinfo byacc flex bison binutils ld gas gcc sid sim gdb make patch prms send-pr gprof gdbtest tgas etc expect dejagnu ash bash bzip2 m4 autoconf automake libtool ispell grep diff rcs cvssrc fileutils shellutils time textutils wdiff find uudecode hello tar gzip indent recode release sed utils guile perl apache inet gawk findutils snavigator libtool gettext zip fastjar"
  
  # libgcj represents the runtime libraries only used by gcj.
  libgcj="target-libffi \

Re: top-level configure.in patch

[DJ Delorie]

Ok, and for gcc too please.

> 2002-06-24  Ben Elliston  <bje@redhat.com>
> 
> 	* configure.in (host_tools): Remove cgen.
> 
> Index: configure.in
> ===================================================================
> RCS file: /cvs/src/src/configure.in,v
> retrieving revision 1.89
> diff -u -p -c -r1.89 configure.in
> *** configure.in	21 Jun 2002 22:20:17 -0000	1.89
> --- configure.in	24 Jun 2002 15:06:38 -0000
> *************** libstdcxx_version="target-libstdc++-v3"
> *** 49,55 ****
>   # these tools are built for the host environment
>   # Note, the powerpc-eabi build depends on sim occurring before gdb in order to
>   # know that we are building the simulator.
> ! host_tools="texinfo byacc flex bison binutils ld gas gcc cgen sid sim gdb make patch prms send-pr gprof gdbtest tgas etc expect dejagnu ash bash bzip2 m4 autoconf automake libtool ispell grep diff rcs cvssrc fileutils shellutils time textutils wdiff find uudecode hello tar gzip indent recode release sed utils guile perl apache inet gawk findutils snavigator libtool gettext zip fastjar"
>   
>   # libgcj represents the runtime libraries only used by gcj.
>   libgcj="target-libffi \
> --- 49,55 ----
>   # these tools are built for the host environment
>   # Note, the powerpc-eabi build depends on sim occurring before gdb in order to
>   # know that we are building the simulator.
> ! host_tools="texinfo byacc flex bison binutils ld gas gcc sid sim gdb make patch prms send-pr gprof gdbtest tgas etc expect dejagnu ash bash bzip2 m4 autoconf automake libtool ispell grep diff rcs cvssrc fileutils shellutils time textutils wdiff find uudecode hello tar gzip indent recode release sed utils guile perl apache inet gawk findutils snavigator libtool gettext zip fastjar"
>   
>   # libgcj represents the runtime libraries only used by gcj.
>   libgcj="target-libffi \
>