Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@science.uva.nl>
To: Jim Blandy <jimb@zwingli.cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: i386 Linux: provide correct type for orig_eax register
Date: Sat, 12 Jan 2002 05:13:00 -0000	[thread overview]
Message-ID: <s3izo3j1zlk.fsf@soliton.wins.uva.nl> (raw)
In-Reply-To: Jim Blandy's message of Fri, 11 Jan 2002 17:24:48 -0500 (EST)

Jim Blandy <jimb@zwingli.cygnus.com> writes:

> This fixes a failure in callfuncs.exp.

What failure?

> 2002-01-11  Jim Blandy  <jimb@redhat.com>
> 
> 	Return the correct virtual type for orig_eax.
> 	* i386-linux-tdep.c (i386_linux_register_virtual_type): New function.
> 	* config/i386/tm-linux.h (i386_linux_register_virtual_type): New
> 	declaration.
> 	(REGISTER_VIRTUAL_TYPE): Override definition in tm-i386.h; use the
> 	Linux-specific version.

Hmm.  You're compiling GDB on a system that doesn't have
PTRACE_GETFPXREGS in <sys/ptrace.h> isn't it?  In that case, I think
your patch is just papering over a more fundamental flaw in the
Linux/x86 port: not always including the SSE registers in the register
file.

I think we should #define HAVE_SSE_REGS unconditionally in
config/i386/tm-linux.h.  Later, when things are properly multi-arched,
we can decide whether we actually display thos registers based on the
actual processor model.

Mark


  reply	other threads:[~2002-01-12 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-11 14:23 Jim Blandy
2002-01-12  5:13 ` Mark Kettenis [this message]
2002-01-12 15:14   ` Jim Blandy
2002-01-12 15:40     ` Andrew Cagney
2002-01-14 13:58       ` Jim Blandy
2002-01-14 14:31         ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s3izo3j1zlk.fsf@soliton.wins.uva.nl \
    --to=kettenis@science.uva.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@zwingli.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox