From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23254 invoked by alias); 12 Jan 2002 13:13:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23211 invoked from network); 12 Jan 2002 13:13:48 -0000 Received: from unknown (HELO mail.science.uva.nl) (146.50.4.51) by sources.redhat.com with SMTP; 12 Jan 2002 13:13:48 -0000 Received: from soliton.wins.uva.nl [146.50.20.20] by mail.science.uva.nl with ESMTP (sendmail 8.11.6/config 11.24). id g0CDDfL19545; Sat, 12 Jan 2002 14:13:41 +0100 (MET) Received: from localhost by soliton.wins.uva.nl (sendmail 8.11.6/config 11.15). id g0CDDhf04476; Sat, 12 Jan 2002 14:13:43 +0100 (MET) X-Organisation: Faculty of Science, University of Amsterdam, The Netherlands X-URL: http://www.science.uva.nl/ To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: i386 Linux: provide correct type for orig_eax register References: <20020111222448.A73EC5E9D8@zwingli.cygnus.com> From: Mark Kettenis Date: Sat, 12 Jan 2002 05:13:00 -0000 In-Reply-To: Jim Blandy's message of Fri, 11 Jan 2002 17:24:48 -0500 (EST) Message-ID: X-Mailer: Gnus v5.5/Emacs 20.2 X-SW-Source: 2002-01/txt/msg00324.txt.bz2 Jim Blandy writes: > This fixes a failure in callfuncs.exp. What failure? > 2002-01-11 Jim Blandy > > Return the correct virtual type for orig_eax. > * i386-linux-tdep.c (i386_linux_register_virtual_type): New function. > * config/i386/tm-linux.h (i386_linux_register_virtual_type): New > declaration. > (REGISTER_VIRTUAL_TYPE): Override definition in tm-i386.h; use the > Linux-specific version. Hmm. You're compiling GDB on a system that doesn't have PTRACE_GETFPXREGS in isn't it? In that case, I think your patch is just papering over a more fundamental flaw in the Linux/x86 port: not always including the SSE registers in the register file. I think we should #define HAVE_SSE_REGS unconditionally in config/i386/tm-linux.h. Later, when things are properly multi-arched, we can decide whether we actually display thos registers based on the actual processor model. Mark