From: David Carlton <carlton@math.stanford.edu>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: gdb/709, C++ static members
Date: Wed, 18 Sep 2002 10:38:00 -0000 [thread overview]
Message-ID: <ro1hegntczn.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <20020918154026.GA24749@nevyn.them.org>
On Wed, 18 Sep 2002 11:40:26 -0400, Daniel Jacobowitz <drow@mvista.com> said:
> David, your earlier patch:
> * values.c (value_static_field): Treat an unresolved location the
> same as a nonexistent symbol. Fix PR gdb/635.
> pointed me in the right direction for this fix. As you may have
> pointed out at the time, read_var_value does basically the same
> thing your fix does in that case. It turns out that there's some
> other cases - this particular one was LOC_CONST_BYTES - where
> read_var_value does the right thing and value_static_field doesn't.
> So I just had value_static_field call read_var_value, which fixes
> your testcase and also a new one I'll post later for gdb/709.
Interesting. I definitely want to think more about whose job it
should be to handle LOC_UNRESOLVED - it seems plausible that
LOC_UNRESOLVED symbols should never be allowed to escape from
lookup_symbol - but now it seems that I have more location classes to
consider. Hmm.
David Carlton
carlton@math.stanford.edu
next prev parent reply other threads:[~2002-09-18 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 8:40 Daniel Jacobowitz
2002-09-18 10:38 ` David Carlton [this message]
2002-09-18 10:55 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ro1hegntczn.fsf@jackfruit.Stanford.EDU \
--to=carlton@math.stanford.edu \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox